From: sashiko-bot@kernel.org
To: "James Clark" <james.clark@linaro.org>
Cc: linux-perf-users@vger.kernel.org
Subject: Re: [PATCH 1/2] perf test: Remove redundant shellcheck source paths
Date: Mon, 21 Sep 2026 15:50:59 +0000 [thread overview]
Message-ID: <20260921155059.E0F571F000FF@smtp.kernel.org> (raw)
In-Reply-To: <20260921-james-perf-shellcheck-source-v1-1-adcfc107c997@linaro.org>
> The minimum required shellcheck version treats paths with leading
> variables as starting from the script's current directory, so shellcheck
> is able to source all of these files without needing the extra
> directives:
>
> v0.7.2 - 2021-04-19
>
> Changed
> * SC1090: A leading $x/ or $(x)/ is now treated as ./ when locating files
>
> Remove them to avoid future copy pasting and confusion that they are
> required. Because the paths weren't actually followed, they didn't have
> to be accurate and accepted any string to silence the warning.
>
> Signed-off-by: James Clark <james.clark@linaro.org>
Sashiko has reviewed this patch and found no issues. It looks great!
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260921-james-perf-shellcheck-source-v1-0-adcfc107c997@linaro.org?part=1
next prev parent reply other threads:[~2026-09-21 15:51 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-21 15:47 [PATCH 0/2] perf test: Improve shellcheck source directives James Clark
2026-09-21 15:47 ` [PATCH 1/2] perf test: Remove redundant shellcheck source paths James Clark
2026-09-21 15:50 ` sashiko-bot [this message]
2026-09-21 15:47 ` [PATCH 2/2] perf build: Follow sourced files when running shellcheck James Clark
2026-09-21 15:56 ` sashiko-bot
2026-09-21 20:46 ` [PATCH 0/2] perf test: Improve shellcheck source directives Namhyung Kim
2026-09-24 17:50 ` Arnaldo Carvalho de Melo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260921155059.E0F571F000FF@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=james.clark@linaro.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox