Re: [PATCH v3 3/7] perf annotate-data: Resolve type DIEs in the debug file they came from

[sashiko-bot@kernel.org]

> From: Arnaldo Carvalho de Melo <acme@redhat.com>
> 
> 'perf report -s type' hangs, burning all of a CPU with no output, when
> resolving a hist entry on the dwz compressed debug info of libz.so.1
> (zlib-ng): die_collect_vars() saves the dwarf_dieoffset() of the type
> DIE, which is relative to the file it lives in - the dwz alt file for
> the types shared by more than one CU - and update_var_state() resolves
> that offset in the main debug file, where it parses whatever is at that
> offset, here a typedef whose DW_AT_type refers to itself, making the
> type chase spin forever.
> 
> Record whether the type DIE came from the alt file and resolve the
> offset with die_get_type_die() in that file, with no fallback:
> resolving an alt file offset in the main file is exactly the misparse
> above.
> 
> Fixes: 06b2ce75386df04b ("perf annotate-data: Maintain variable type info")
> Fixes: 55ee3d005d62279d ("perf annotate-data: Add a cache for global variable types")
> Assisted-by: LLM
> Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>

Sashiko has reviewed this patch and found no issues. It looks great!

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260922122623.1029132-1-acme@kernel.org?part=3