Re: [PATCH v3 4/6] perf script: Add --max-symbol-bytes to bound ELF symbol memory

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] perf: missing <string.h> inclusion for string functions
--

commit 79450839068bd1d9b33fd4d112e056707965c93e
Author: Alireza Haghdoost <haghdoost@uber.com>

perf script: Add --max-symbol-bytes to bound ELF symbol memory

This commit adds a --max-symbol-bytes option to perf script to bound the
memory footprint of struct symbol allocations on the ELF loader path. Once
the budget is exceeded, it stops loading symbols and leaves unresolved
addresses as [unknown].

> diff --git a/tools/perf/builtin-script.c b/tools/perf/builtin-script.c
> index 0174489d1c0fd..6c459ce6f433e 100644
> --- a/tools/perf/builtin-script.c
> +++ b/tools/perf/builtin-script.c
[ ... ]
> @@ -4110,6 +4111,44 @@ static int parse_callret_trace(const struct option *opt __maybe_unused,
>  	return 0;
>  }
>  
> +static int parse_max_symbol_bytes(const struct option *opt,
> +				  const char *str, int unset)
> +{
[ ... ]
> +	if (!strcmp(str, "0")) {
> +		*max_bytes = 0;
> +		return 0;
> +	}
> +
> +	len = strlen(str);
> +	if (len < 2 || !strchr("BKMG", str[len - 1]) ||
> +	    strspn(str, "0123456789") != len - 1)

[Severity: Low]
Does this file need an explicit #include <string.h>?

The new parse_max_symbol_bytes() function relies on POSIX string functions 
(strcmp, strlen, strchr, strspn). To ensure build compatibility across standard
C libraries like musl, standard header files should be explicitly included
rather than relying on implicit inclusion from other headers.

> +		return -1;
> +
> +	bytes = parse_tag_value(str, size_tags);
> +	if (bytes != (unsigned long)-1) {
> +		*max_bytes = bytes;
> +		return 0;
> +	}
> +
> +	return -1;
> +}

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260925-perf-symbol-memory-send-v3-0-3e4e234c363b@uber.com?part=4