Re: [PATCH 1/1] perf: Fix Python 3.6 build breakage in jevents.py and util/setup.py

[sashiko-bot@kernel.org]

> perf's build still accepts Python 3.6: Makefile.config only rejects
> interpreters older than 3.6 and jevents.py keeps its own removesuffix()
> shim for it, but two recently added constructs are evaluated when the
> module or the function is defined and only work on newer interpreters.
> 
> PEP 585's list[...] became subscriptable in Python 3.9, so the module
> level annotations in jevents.py make Kbuild die at import time:
> 
>   TypeError: 'type' object is not subscriptable
>   make[3]: *** [pmu-events/Build:176: .../test-empty-pmu-events.c] Error 1
> 
> as seen on almalinux:8 with its python3.6.8, and the list[str]
> parameters of util/setup.py's functions fail the same way when the
> python binding is built.
> 
> [ ... ]
> Fixes: cda907c2c3f99 ("perf jevents: Add python type annotations")
> Fixes: 1fa8d81be1eb ("perf python: Clean up and restructure setup.py")
> Fixes: eaab2eb09dc2 ("perf pmu-events: Parallelize JSON and metric pre-computation in jevents.py")
> Assisted-by: LLM
> Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>

Sashiko has reviewed this patch and found no issues. It looks great!

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/arbd4TJm4s9MVjN-@x2?part=1