Re: [PATCH 1/1] perf tools: Bump the minimum Python version to 3.9

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] perf: incomplete python 3.9 version check leads to build crash
--

commit 7a016e98c4330410787d9ac22be5c76fe463b5ce
Author: Arnaldo Carvalho de Melo <acme@kernel.org>

perf tools: Bump the minimum Python version to 3.9

This commit bumps the minimum Python version required by the perf build
from 3.6 to 3.9. It replaces the custom removesuffix() implementation
with the built-in str.removesuffix() and updates the version check in
Makefile.config.

> diff --git a/tools/perf/Makefile.config b/tools/perf/Makefile.config
> index 0ba307e78fe1f..549a809a88ca2 100644
> --- a/tools/perf/Makefile.config
> +++ b/tools/perf/Makefile.config
> @@ -876,10 +876,12 @@ ifneq ($(NO_JEVENTS),1)
>    ifndef PYTHON
>      $(error ERROR: No python interpreter needed for jevents generation. Install python or build with NO_JEVENTS=1.)
>    else
> -    # jevents.py uses f-strings present in Python 3.6 released in Dec. 2016.
> -    JEVENTS_PYTHON_GOOD := $(shell $(PYTHON) -c 'import sys;print("1" if(sys.version_info.major >= 3 and sys.version_info.minor >= 6) else "0")' 2> /dev/null)
> +    # Minimum Python version, the same one the kernel requires, see
> +    # Documentation/process/changes.rst: jevents.py needs PEP 585 generics,
> +    # list[...] and friends, that are subscriptable from Python 3.9.
> +    JEVENTS_PYTHON_GOOD := $(shell $(PYTHON) -c 'import sys;print("1" if sys.version_info >= (3, 9) else "0")' 2> /dev/null)
>      ifneq ($(JEVENTS_PYTHON_GOOD), 1)
> -      $(error ERROR: Python interpreter needed for jevents generation too old (older than 3.6). Install a newer python or build with NO_JEVENTS=1.)
> +      $(error ERROR: Python interpreter needed for jevents generation too old (older than 3.9). Install a newer python or build with NO_JEVENTS=1.)

[Severity: Low]
If a user with an older Python version follows the suggestion to build
with NO_JEVENTS=1, won't the build crash later on?

Because this version check is inside the ifneq ($(NO_JEVENTS),1) block,
setting NO_JEVENTS=1 bypasses it. However, tools/perf/util/setup.py also
requires Python 3.9 for the PEP 585 list[str] generic in functions like
clang_has_option():

tools/perf/util/setup.py:clang_has_option() {
    def clang_has_option(cc: str, cc_args: list[str], ...
}

When the build reaches setup.py to build the Python bindings (unless
NO_LIBPYTHON=1 is also specified), won't it fail with a cryptic TypeError
("'type' object is not subscriptable") instead of a clean Makefile error?

Should this Python 3.9 version requirement be enforced globally rather than
just for jevents generation, or should the suggestion to use NO_JEVENTS=1
be removed?

>      endif
>    endif
>  endif

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/arb9OMEQ8HCcw-9O@x2?part=1