From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dy1-f200.google.com (mail-dy1-f200.google.com [74.125.82.200]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2D9CD4EE85D for ; Mon, 28 Sep 2026 16:36:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.200 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790613415; cv=none; b=QTtcqVqb7wpQZMR0N96Qe+MqBUOaA5JTIxLOr1/9ctN6mjZ1IxzpNxmYpwSoaZyO1B+jXvp4HJQbYjm5NKmwwDSK7XMtidaiYZ+DkCNu8p5CeGy+LwALJzZwQ1dY2FONZ5j3zBjHnmnF6yG5b5sEBofElJ+e4PHnmrTEH3YkBV8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790613415; c=relaxed/simple; bh=Eqixr+77YuATos4ItPsUHXM9VuOTHs/di3E3c0Bb5C0=; h=Date:Mime-Version:Message-ID:Subject:From:To:Content-Type; b=jMNs8hjH/kNmoorsuQC19oUNiEjPiBNNeU+trRdS7z3TIFo7GvTuTU2Je6REc7UPxPyJgQaHlLVH0wBIz1mtpT3PsJQ5BBn9kOJE0G4d6h6r8QAU1og/t4mnpcoK3xvUEAkO6tRtgFx0UreccTclXkIFVxUuVEI5teT3pCGf9mk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--irogers.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=fyfrnSLd; arc=none smtp.client-ip=74.125.82.200 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--irogers.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="fyfrnSLd" Received: by mail-dy1-f200.google.com with SMTP id 5a478bee46e88-30c0d568830so6795991eec.1 for ; Mon, 28 Sep 2026 09:36:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1790613413; x=1791218213; darn=vger.kernel.org; h=content-type:to:from:subject:message-id:mime-version:date:from:to :cc:subject:date:message-id:reply-to:content-type; bh=KlBCVlT+hyZcroorsvNsasD4unmnXb0AYHxMzW4V8n0=; b=fyfrnSLdRLkG0L0WsOP28RXjP21ksSeai+R/r1QsfeggTIEN8JQlMK0Xc7T0JEamVR /FXLqwth2C9WjgBjOYOMVR1VzeC9l6OAXOYZaZfanX1icO6XdptAj0Ob0k9QjP7yPTEL gDrHZoRM/eCehv0mocCKmEEXwdaNNoQCv7zZeIuCNnqiJFBMSNJdShmZPZ0U4RwcCTVs ivuwend150hpqRzBKzhMpW9lcq2euboUjpNODmab/Eps5i/Af35PsCsLFpcrC6eXhz0u 7h8H0bKljeszu6aINGR8fK8EAf9cyf+aK4xHUIg7mOyDz2H4wKddTSDqPPo2qEGZy6Bt We7w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1790613413; x=1791218213; h=content-type:to:from:subject:message-id:mime-version:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=KlBCVlT+hyZcroorsvNsasD4unmnXb0AYHxMzW4V8n0=; b=kAlNyDjsRZexCJpG+KNcwilVTIcttusy0RoUt5Oyg2YYOoMpN/PLgHNEIz58r7leTz YCsHqT+2AvBUmZNv9iO5amqnIz0HInlZwhy1AvnkQ/AAQlYCPFAVTpAqhG4DzLBmr6wS VsYK9Kwf34NLVno+TIPRxqPtIcYiyglm10z+Ww8xO3DxGbU80GEnPHbgOBBADiT5Hn8u Ab9w70c4gDywV3yVBSK7zFuM7n/Q9h7eXxRLyQQqei4chtMST4j6BG1vu3RMj+EDrTxT 8u2Y0F7+HA7lNBxU8Sy9mvjtPcSha3RCmKYyvZ6hp+DEBPyzWDpIbTLVmdl8S7fM1n05 wH+Q== X-Forwarded-Encrypted: i=1; AKwUvBwFeldTse0b8cgPNVexrbfCgc4FTJUrjpdHpusD6uxLraW8btTawNXM1rOpa1aIWi+w9TbGaSJJnNoIZ3I2PWBB@vger.kernel.org X-Gm-Message-State: AFq9FYI7/IadKo7NdDMC2FgIiGSgF06WpmZgLw66gXebXkYAaFWTbzm+ PmUjPHNqgh6XGKiWIap+oBdVReFx3jaoAkNKJ4kAY3Xugkuz3X6HE3iTi/m70FMswixjSe0QhUU SfRFnojmd+g== X-Received: from dydb10.prod.google.com ([2002:a05:7300:80ca:b0:33e:63db:5570]) (user=irogers job=prod-delivery.src-stubby-dispatcher) by 2002:a05:693c:26cc:b0:33f:45d1:8f24 with SMTP id 5a478bee46e88-3427246b702mr9636085eec.22.1790613412580; Mon, 28 Sep 2026 09:36:52 -0700 (PDT) Date: Mon, 28 Sep 2026 09:36:49 -0700 Precedence: bulk X-Mailing-List: linux-perf-users@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 X-Mailer: git-send-email 2.56.0.rc1.315.gc6ed9934b7-goog Message-ID: <20260928163649.3463451-1-irogers@google.com> Subject: [PATCH v1] perf build: Clean libperf-gtk.so in 'make clean' From: Ian Rogers To: Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Namhyung Kim , Jiri Olsa , Ian Rogers , Adrian Hunter , James Clark , linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" When GTK support was made opt-in (first via GTK2=1 and recently ported to GTK4=1), $(OUTPUT)libperf-gtk.so is only added to ALL_PROGRAMS when GTK4 is defined. As a result, running 'make clean' without GTK4=1 does not remove $(OUTPUT)libperf-gtk.so. Add $(OUTPUT)libperf-gtk.so explicitly to the core-progs clean list so it is always removed by 'make clean'. Fixes: 4751bddd3f983af2 ("perf tools: Make GTK2 support opt-in") Reported-by: Ian Rogers Closes: https://lore.kernel.org/linux-perf-users/CAP-5=fV6+mzN3Lf_mCAJ4aP42JFZsF55ekvt8XrX505xOWwrmA@mail.gmail.com/ Assisted-by: Antigravity:gemini-3.1-pro Signed-off-by: Ian Rogers --- tools/perf/Makefile.perf | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/perf/Makefile.perf b/tools/perf/Makefile.perf index 5e89ff37d5b0..c35316bf5e09 100644 --- a/tools/perf/Makefile.perf +++ b/tools/perf/Makefile.perf @@ -985,7 +985,7 @@ clean:: $(LIBAPI)-clean $(LIBBPF)-clean $(LIBSUBCMD)-clean $(LIBSYMBOL)-clean $( -name '*.mypy_log' -delete -o -name '*.pylint_log' -delete $(Q)$(RM) $(OUTPUT).config-detected $(call QUIET_CLEAN, core-progs) $(RM) $(ALL_PROGRAMS) perf perf-read-vdso32 \ - perf-read-vdsox32 $(OUTPUT)$(LIBJVMTI).so + perf-read-vdsox32 $(OUTPUT)$(LIBJVMTI).so $(OUTPUT)libperf-gtk.so $(call QUIET_CLEAN, core-gen) $(RM) *.spec *.pyc *.pyo */*.pyc */*.pyo \ TAGS tags cscope* $(OUTPUT)PERF-VERSION-FILE \ $(OUTPUT)FEATURE-DUMP $(OUTPUT)util/*-bison* $(OUTPUT)util/*-flex* \ -- 2.56.0.rc1.315.gc6ed9934b7-goog