Linux Perf Users
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Chun-Tse Shao" <ctshao@google.com>
Cc: linux-perf-users@vger.kernel.org
Subject: Re: [PATCH 1/2] perf jevents: Add NVIDIA Tegra410 uncore DDR metrics
Date: Mon, 28 Sep 2026 18:00:56 +0000	[thread overview]
Message-ID: <20260928180056.9CF6D1F000FF@smtp.kernel.org> (raw)
In-Reply-To: <20260928175127.1032535-2-ctshao@google.com>

> Add DDR bandwidth and latency metrics for the NVIDIA Tegra410 SoC. The
> formulas follow Documentation/admin-guide/perf/nvidia-tegra410-pmu.rst:
> 
>   AVG_MEM_READ_BANDWIDTH_IN_GBPS = MEM_BYTES_RD / ELAPSED_TIME_IN_NS
>   AVG_MEM_WRITE_BANDWIDTH_IN_GBPS = MEM_BYTES_WR / ELAPSED_TIME_IN_NS
> 
>   FREQ_IN_GHZ = CYCLES / ELAPSED_TIME_IN_NS
>   AVG_LATENCY_IN_CYCLES = RD_CUM_OUTS / RD_REQ
>   AVERAGE_LATENCY_IN_NS = AVG_LATENCY_IN_CYCLES / FREQ_IN_GHZ
> 
> The bandwidth metrics use the mem_bytes_rd/mem_bytes_wr events of the
> Unified Coherence Fabric (UCF) PMU with source/destination filters:
> 
>   lpm_ddr_bw, lpm_ddr_rd_bw, lpm_ddr_wr_bw: all sources to local CMEM.
>   lpm_ddr_loc_rd_bw, lpm_ddr_loc_wr_bw: local CPU and non-CPU sources to
> [ ... ]
> pmu-events/Build only runs arm64_metrics.py for the "arm" vendor models,
> so also run it for the "nvidia" vendor models to generate the Tegra410
> metrics.
> 
> Signed-off-by: Chun-Tse Shao <ctshao@google.com>

Sashiko has reviewed this patch and found no issues. It looks great!

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260928175127.1032535-1-ctshao@google.com?part=1


  reply	other threads:[~2026-09-28 18:00 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-28 17:51 [PATCH 0/2] perf jevents: Add NVIDIA Tegra410 uncore DDR and PCIe metrics Chun-Tse Shao
2026-09-28 17:51 ` [PATCH 1/2] perf jevents: Add NVIDIA Tegra410 uncore DDR metrics Chun-Tse Shao
2026-09-28 18:00   ` sashiko-bot [this message]
2026-09-28 17:51 ` [PATCH 2/2] perf jevents: Add NVIDIA Tegra410 uncore PCIe metrics Chun-Tse Shao
2026-09-28 17:57   ` sashiko-bot
2026-09-29 18:39 ` [PATCH 0/2] perf jevents: Add NVIDIA Tegra410 uncore DDR and " Arnaldo Carvalho de Melo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260928180056.9CF6D1F000FF@smtp.kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=ctshao@google.com \
    --cc=linux-perf-users@vger.kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox