From: sashiko-bot@kernel.org
To: "Arnaldo Carvalho de Melo" <acme@kernel.org>
Cc: linux-perf-users@vger.kernel.org
Subject: Re: [PATCH 3/4] perf scripts: Add perf-stuck, to tell where a running perf is stuck
Date: Mon, 28 Sep 2026 22:16:14 +0000 [thread overview]
Message-ID: <20260928221615.12C1F1F000FF@smtp.kernel.org> (raw)
In-Reply-To: <20260928220634.2451784-4-acme@kernel.org>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] perf scripts: perf-dso GDB command fails on ASan/LSan builds
--
commit 3e959f0b96fd50b6f00f007448b2245cac82c305
Author: Arnaldo Carvalho de Melo <acme@redhat.com>
perf scripts: Add perf-stuck, to tell where a running perf is stuck
This commit introduces a prototype perf-stuck script and accompanying GDB
script to identify where a running perf process is stuck. It samples /proc
entries and can optionally use GDB to dump the DWARF DIE chain.
> diff --git a/tools/perf/scripts/perf-stuck.gdb b/tools/perf/scripts/perf-stuck.gdb
> new file mode 100644
> index 0000000000000..2022f83c6bfdc
> --- /dev/null
> +++ b/tools/perf/scripts/perf-stuck.gdb
[ ... ]
> +define perf-dso
> + if $_any_caller_is("find_data_type", 20)
> + frame function find_data_type
> + # REFCNT_CHECKING, implied by an ASan/LSan build, wraps struct map and
> + # struct dso in a proxy keeping the real object in ->orig, so there the
> + # dso is map->orig->dso->orig, giving map->orig->dso->orig->name here;
> + # struct symbol is not wrapped, so sym->name needs no ->orig.
> + printf "dso=%s ip=0x%lx sym=%s\n", dloc->ms->map->dso->name, dloc->ip, dloc->ms->sym ? dloc->ms->sym->name : "(no symbol)"
[Severity: Low]
Does this command fail on ASan/LSan builds?
The comment correctly notes that REFCNT_CHECKING wraps struct map and struct
dso in a proxy requiring ->orig access, but the printf statement hardcodes
the standard non-ASan access path (dloc->ms->map->dso->name).
This causes the perf-dso GDB macro to fail to evaluate and abort when
running perf-stuck.sh -g against an ASan-instrumented perf process.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260928220634.2451784-1-acme@kernel.org?part=3
next prev parent reply other threads:[~2026-09-28 22:16 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-28 22:06 [PATCH v3 0/4] perf tools: Add progress diagnostics and a false-sharing workload Arnaldo Carvalho de Melo
2026-09-28 22:06 ` [PATCH 1/4] perf config: Move perf_config__set_variable() to util/config.c Arnaldo Carvalho de Melo
2026-09-28 22:19 ` sashiko-bot
2026-09-28 22:06 ` [PATCH 2/4] perf report: Add --progress option Arnaldo Carvalho de Melo
2026-09-28 22:12 ` sashiko-bot
2026-09-29 18:29 ` Namhyung Kim
2026-09-28 22:06 ` [PATCH 3/4] perf scripts: Add perf-stuck, to tell where a running perf is stuck Arnaldo Carvalho de Melo
2026-09-28 22:16 ` sashiko-bot [this message]
2026-09-29 18:31 ` Namhyung Kim
2026-09-28 22:06 ` [PATCH 4/4] perf test: Add false_sharing workload exhibiting cross-CPU false sharing Arnaldo Carvalho de Melo
2026-09-28 22:14 ` sashiko-bot
-- strict thread matches above, loose matches on Subject: below --
2026-09-28 16:22 [PATCH 0/4 v1] perf tools: Add progress diagnostics and a false-sharing workload Arnaldo Carvalho de Melo
2026-09-28 16:22 ` [PATCH 3/4] perf scripts: Add perf-stuck, to tell where a running perf is stuck Arnaldo Carvalho de Melo
2026-09-28 16:37 ` sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260928221615.12C1F1F000FF@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=acme@kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox