From: sashiko-bot@kernel.org
To: "Namhyung Kim" <namhyung@kernel.org>
Cc: linux-perf-users@vger.kernel.org
Subject: Re: [PATCH v2 4/8] perf tools: Export dso__get_filename() with type argument
Date: Tue, 29 Sep 2026 01:21:01 +0000 [thread overview]
Message-ID: <20260929012101.C0C7F1F000FF@smtp.kernel.org> (raw)
In-Reply-To: <20260929011139.53242-5-namhyung@kernel.org>
> The dso__get_filename() returns a new string of filepath for the given
> binary type. It handles chroot and decompressed kernel modules so that
> callers can read the file contents. Thus it'd be better to use it to
> check available binary types.
>
> Add a type argument to handle a different path for symbol or debug info.
>
> Reviewed-by: Arnaldo Carvalho de Melo <acme@redhat.com>
> Signed-off-by: Namhyung Kim <namhyung@kernel.org>
Sashiko has reviewed this patch and found no issues. It looks great!
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260929011139.53242-1-namhyung@kernel.org?part=4
next prev parent reply other threads:[~2026-09-29 1:21 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-29 1:11 [PATCH v2 0/8] perf tools: Cleanup dso debug info access Namhyung Kim
2026-09-29 1:11 ` [PATCH v2 1/8] perf tools: Add dso->dbginfo_type field Namhyung Kim
2026-09-29 1:18 ` sashiko-bot
2026-09-29 1:11 ` [PATCH v2 2/8] perf tools: Factor out dso__find_dbginfo_type() Namhyung Kim
2026-09-29 1:19 ` sashiko-bot
2026-09-29 1:11 ` [PATCH v2 3/8] perf tools: Check system path when check debuginfo Namhyung Kim
2026-09-29 1:23 ` sashiko-bot
2026-09-29 18:18 ` Namhyung Kim
2026-09-29 18:48 ` Arnaldo Carvalho de Melo
2026-09-29 1:11 ` [PATCH v2 4/8] perf tools: Export dso__get_filename() with type argument Namhyung Kim
2026-09-29 1:21 ` sashiko-bot [this message]
2026-09-29 1:11 ` [PATCH v2 5/8] perf tools: Add dso__put_filename() Namhyung Kim
2026-09-29 1:18 ` sashiko-bot
2026-09-29 1:11 ` [PATCH v2 6/8] perf tools: Avoid repeated failing search for debuginfo Namhyung Kim
2026-09-29 1:25 ` sashiko-bot
2026-09-29 1:11 ` [PATCH v2 7/8] perf tools: Looks symbol file first when check debuginfo Namhyung Kim
2026-09-29 1:27 ` sashiko-bot
2026-09-29 1:11 ` [PATCH v2 8/8] perf tools: Update debuginfo__new() to take DSO Namhyung Kim
2026-09-29 1:18 ` sashiko-bot
2026-09-29 23:58 ` Masami Hiramatsu
2026-09-29 18:58 ` [PATCH v2 0/8] perf tools: Cleanup dso debug info access Arnaldo Carvalho de Melo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260929012101.C0C7F1F000FF@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=namhyung@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox