From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id ECA70189F43 for ; Tue, 29 Sep 2026 01:24:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790645050; cv=none; b=XOdso4vtzN9YSIIc9zcMfZtsCgVivmS5Bi+TLJ9RlqK4mYX5FSarxTTGkRvUDrKTgkxIzqd9NdKZU72ImWCPFYxd2qD1rN1UqdQuY2dpGR3FJqGClBOjxfyyVt8QhxjKZ4XEbK7Xi4/AzgkFUD7DT2Rq0kWy3vaB5LwsP/MoH/I= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790645050; c=relaxed/simple; bh=c3JUQlsplcqSaCIEHfR+duCQLgKg9RFn7QpMu6f88G4=; h=From:Subject:To:Cc:In-Reply-To:References:Content-Type:Date: Message-Id; b=E0fK3M4itsm89/ER+u5nJKeTgRQEgsKRXnSx7Os05kTEyMeW1vR1q+agQ+5oLhYXR0bTWh3QZ8iEzvEED88ddBUTpxtiRBv+pyj8sXmHvHvyw7yb6ei2LHJC4QtcIqJK+0LTy+ERkUAYcKXEoXc/wCarO8pe+9nQKxf+JJNiKUs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=MFm4xRJo; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="MFm4xRJo" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6F85E1F000FF; Tue, 29 Sep 2026 01:24:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1790645048; bh=pB2vqhpHfvYTnj/Ei2DSXwc3fiKbl4QXvWWorSXHKos=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=MFm4xRJoBSwpC5sZoypkB5Yi/jKBwjsk+VpQXWZfgiHxFLSqqwad4dIay/4JHkyiL wCvsjCQQvgfqu2RYxMSgy2EqIGjJSiWWG/x0+nWCtrQ5KoqhT3S2cqnIHBRv61pQjl OWCfHLm6r0iGlaFYeHFK4TjIsczToA9hw7DlZph0w9DkDUOWZBJZ7bem1aS6WKwHyO CXC6g4zIzx8hy8Y6mo2QNSOpKufsxQPejGyfnfbXdLyqcpiz+BFjQhp0en1PK/At5y UYfksNKoV5gM9+dR2FVPhnhfSlFOdMR7CzQcXVet+kCCRJEbE3tdd472KednQMVZH2 OMztM0aey+Ugw== From: sashiko-bot@kernel.org Subject: Re: [PATCH v2 2/2] perf test: Improve JUnit XML schema compliance and completeness Reply-To: sashiko-reviews@lists.linux.dev To: "Ian Rogers" Cc: linux-perf-users@vger.kernel.org In-Reply-To: <20260929011837.4157334-2-irogers@google.com> References: <20260928210144.3925224-1-irogers@google.com> <20260929011837.4157334-1-irogers@google.com> <20260929011837.4157334-2-irogers@google.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Tue, 29 Sep 2026 01:24:07 +0000 Message-Id: <20260929012408.6F85E1F000FF@smtp.kernel.org> Precedence: bulk X-Mailing-List: linux-perf-users@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: > Improve the JUnit XML output generated by 'perf test -j' so that it > validates cleanly against both the strict Apache Ant/Windy Road JUnit > schema (JUnit.xsd) and the Jenkins xUnit/Maven Surefire schema > (junit-10.xsd): > - Add the required 'package', 'id', 'timestamp' (ISO 8601 UTC), > 'hostname', and 'time' attributes to ''. > - Emit '' (populated with uname sysname, release, version, > and machine when available) at the start of '' and > '' and '' at the end, matching the element > sequence required by JUnit.xsd. > - Add the required 'type=3D"failure"' attribute to '' elements > and emit self-closing tags for passing '' elements and > ''/'' elements with empty error output. > - Escape apostrophes (''') and validate UTF-8 multi-byte sequences > against valid XML 1.0 codepoints in xml_escape(). > - Use the actual suite description and '%.2f' time format for user > override skipped tests ('-s'/'--skip'). > - Document '-j[]'/'--junit[=3D]' in perf-test.txt. >=20 > Assisted-by: Antigravity:gemini-3.1-pro > Signed-off-by: Ian Rogers Sashiko has reviewed this patch and found no issues. It looks great! --=20 Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20260929011837.4157= 334-1-irogers@google.com?part=3D2