From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AD9D83D3D05 for ; Tue, 29 Sep 2026 02:59:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790650746; cv=none; b=vFTowhlKWZBqEYUI8JUSTOPYhHAxwmWf/4QV/Q4FNIJ+hxJayyuONLsyKZGQ2vZcmTYEroNfewADcOIv2/WY5GXr+Kr8l39arurZj65Qd8vouP7s4nVI5AlkIkZny+m5eBYBlG1wcUIXJjO2egO4s960pkxENgbGelkTSSOrPVY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790650746; c=relaxed/simple; bh=Z0to22eDYUP6b+r1KiYdgWHRwvDxVi2nZVmt+TRFXIE=; h=From:Subject:To:Cc:In-Reply-To:References:Content-Type:Date: Message-Id; b=OZkWQjOdp6zo9IAVsmVXA7t4IJeXINdY5+V9rHPRZAk9eDV61h3e/W1u13H8HOMpa28e98Q829opaobwGYw9yt7ovWV/PawMPaSMb/B7sOjBe6c2he8B+ULFidrel4yo8FKpn5ZTkReurIqwKl0+19vSLsfafAMARVV0MWv3GnE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=bZ07bZMW; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="bZ07bZMW" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 463AF1F000FF; Tue, 29 Sep 2026 02:59:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1790650742; bh=ranCux+8gKb71oiVq01Lj0GK+tuhfak3VpCQLrOk+nU=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=bZ07bZMWDuLy1eSgOJoJi8ZpIC5ptJ+75trwcKQsug1qTmH/SVfsfCwCjr4PBZWl4 UFt64eFcL2d0ocRRtjC1g6fRUtQKBM7zEXn0Ww/EuJYZG1z8MkVNCcNKShDsj59qJ6 epGejlDnJiOP6t6njd4aFmXN6Dk7+036YeqztFf7onAwyWI2QdS0lax4N4hrEsQAcg AShrUJOQwKgi6iKmXNBktrKNW2COMc0wkgMuoq1CPzTuU3oU//8h0wm/HhEgoz2/sx ngj3pZ3fJpSQIA6jkckkjGadjrorp6uT0j2ARBWlw4EHbjirqQAr2ONEfV3Ey+Fbj7 kx3dPDphUQ/bA== From: sashiko-bot@kernel.org Subject: Re: [PATCH v3 2/2] perf test: Improve JUnit XML schema compliance and completeness Reply-To: sashiko-reviews@lists.linux.dev To: "Ian Rogers" Cc: linux-perf-users@vger.kernel.org In-Reply-To: <20260929025345.88829-2-irogers@google.com> References: <20260929011837.4157334-1-irogers@google.com> <20260929025345.88829-1-irogers@google.com> <20260929025345.88829-2-irogers@google.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Tue, 29 Sep 2026 02:59:01 +0000 Message-Id: <20260929025902.463AF1F000FF@smtp.kernel.org> Precedence: bulk X-Mailing-List: linux-perf-users@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: > Improve the JUnit XML output generated by 'perf test -j' so that it > validates cleanly against both the strict Apache Ant/Windy Road JUnit > schema (JUnit.xsd) and the Jenkins xUnit/Maven Surefire schema > (junit-10.xsd): > - Add the required 'package', 'id', 'timestamp' (ISO 8601 UTC), > 'hostname', and 'time' attributes to ''. > - Emit '' (populated with uname sysname, release, version, > and machine when available) at the start of '' and > '' and '' at the end, matching the element > sequence required by JUnit.xsd. > - Add the required 'type=3D"failure"' attribute to '' elements > and emit self-closing tags for passing '' elements and > ''/'' elements with empty error output. > - Escape apostrophes (''') and validate UTF-8 multi-byte sequences > against valid XML 1.0 codepoints in xml_escape(). > - Use the actual suite description and '%.2f' time format for user > override skipped tests ('-s'/'--skip'). > - Document '-j[]'/'--junit[=3D]' in perf-test.txt. >=20 > Assisted-by: Antigravity:gemini-3.1-pro > Signed-off-by: Ian Rogers Sashiko has reviewed this patch and found no issues. It looks great! --=20 Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20260929025345.8882= 9-1-irogers@google.com?part=3D2