From: sashiko-bot@kernel.org
To: "Leo Yan" <leo.yan@arm.com>
Cc: linux-perf-users@vger.kernel.org
Subject: Re: [PATCH 1/3] perf build: Build the Python extension before pylint consumers
Date: Wed, 30 Sep 2026 09:15:25 +0000 [thread overview]
Message-ID: <20260930091525.B98E41F000FF@smtp.kernel.org> (raw)
In-Reply-To: <20260930-perf_fix_pylint_errors-v1-1-f72151d8b255@arm.com>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] perf build: parallel compilation serialized due to order-only dependency
--
commit b4e3b80b8bd24b069f41f7f4f4f217b8194d4514
Author: Leo Yan <leo.yan@arm.com>
perf build: Build the Python extension before pylint consumers
This commit delays the perf and perf-test sub-makes until the Python
extension is built when pylint is enabled. This is intended to prevent
an import error that stops parallel builds before the extension is available.
> diff --git a/tools/perf/Makefile.perf b/tools/perf/Makefile.perf
> index 0102c3468a0b7..d350d085542c6 100644
> --- a/tools/perf/Makefile.perf
> +++ b/tools/perf/Makefile.perf
> @@ -578,6 +578,12 @@ strip: $(PROGRAMS) $(OUTPUT)perf
> $(STRIP) $(STRIP_OPTS) $(PROGRAMS) $(OUTPUT)perf
>
> PERF_IN := $(OUTPUT)perf-in.o
> +
> +ifdef PYLINT
> +# Build the Python extension before starting sub-makes that lint its users.
> +$(PERF_IN) $(LIBPERF_TEST_IN): | $(LANG_BINDINGS)
[Severity: Low]
Does this order-only dependency block the $(PERF_IN) sub-make from executing
until $(LANG_BINDINGS) and all its prerequisites (including $(LIBPERF_UTIL))
are fully built?
$(PERF_IN) launches the sub-make that compiles all builtin-*.c files.
Meanwhile, $(LANG_BINDINGS) depends on $(PERFLIBS_PY), which launches the
sub-make that compiles all util/*.c files.
Does this completely serialize the compilation of the builtin/ directory
behind the full compilation of the util/ directory and the Python extension,
impacting concurrent parallel build efficiency?
Furthermore, does it force an isolated make perf to needlessly build the
Python extension when PYLINT is enabled on the host?
> +endif
> +
> export NO_JEVENTS
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260930-perf_fix_pylint_errors-v1-0-f72151d8b255@arm.com?part=1
next prev parent reply other threads:[~2026-09-30 9:15 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-30 9:01 [PATCH 0/3] perf build: Fix pylint build failures Leo Yan
2026-09-30 9:01 ` [PATCH 1/3] perf build: Build the Python extension before pylint consumers Leo Yan
2026-09-30 9:15 ` sashiko-bot [this message]
2026-09-30 11:12 ` Leo Yan
2026-09-30 9:01 ` [PATCH 2/3] perf build: Add the output Python directory to pylint's PYTHONPATH Leo Yan
2026-09-30 9:07 ` sashiko-bot
2026-09-30 9:01 ` [PATCH 3/3] perf test: Suppress optparse deprecation warning with older pylint Leo Yan
2026-09-30 9:04 ` sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260930091525.B98E41F000FF@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=leo.yan@arm.com \
--cc=linux-perf-users@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox