From: sashiko-bot@kernel.org
To: "Thorsten Blum" <blum@kernel.org>
Cc: linux-perf-users@vger.kernel.org
Subject: Re: [PATCH RESEND] perf/x86/core: Simplify hybrid PMU registration failure path
Date: Wed, 30 Sep 2026 20:26:40 +0000 [thread overview]
Message-ID: <20260930202641.01DE61F000FF@smtp.kernel.org> (raw)
In-Reply-To: <20260930202016.111577-3-blum@kernel.org>
> Handle perf_pmu_register() errors directly instead of breaking out of
> the registration loop and checking the index separately. Reuse the loop
> index i to unregister any previously registered PMUs in reverse order
> and drop the extra index j.
>
> Also log the failing PMU's name and error code.
>
> Reviewed-by: Dapeng Mi <dapeng1.mi@linux.intel.com>
> Signed-off-by: Thorsten Blum <blum@kernel.org>
Sashiko has reviewed this patch and found no issues. It looks great!
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260930202016.111577-3-blum@kernel.org?part=1
prev parent reply other threads:[~2026-09-30 20:26 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-30 20:20 [PATCH RESEND] perf/x86/core: Simplify hybrid PMU registration failure path Thorsten Blum
2026-09-30 20:26 ` sashiko-bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260930202641.01DE61F000FF@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=blum@kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox