From: sashiko-bot@kernel.org
To: "Stephen Brennan" <stephen.s.brennan@oracle.com>
Cc: linux-perf-users@vger.kernel.org
Subject: Re: [PATCH 1/2] tools: perf: add perf_input_name() helper
Date: Fri, 02 Oct 2026 09:12:52 +0000 [thread overview]
Message-ID: <20261002091258.49AED1F000FF@smtp.kernel.org> (raw)
In-Reply-To: <20261001182004.1160406-2-stephen.s.brennan@oracle.com>
> The perf scripting API does not expose the name of the input file being
> processed. Some scripts, like flamegraph.py, assume that the "-i" option
> will be passed through, but when perf actually processes "-i", it does
> not keep it on the command line for the script. (This could break some
> scripts which do not expect it.)
>
> To allow scripts to know what file they're processing, add a new helper
> perf_input_name(), which returns either the filename being processed, or
> None for an unnamed pipe.
>
> Signed-off-by: Stephen Brennan <stephen.s.brennan@oracle.com>
Sashiko has reviewed this patch and found no issues. It looks great!
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261001182004.1160406-1-stephen.s.brennan@oracle.com?part=1
next prev parent reply other threads:[~2026-10-02 9:12 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-01 18:19 [PATCH 0/2] perf script flamegraph: Fix input file name errors Stephen Brennan
2026-10-01 18:20 ` [PATCH 1/2] tools: perf: add perf_input_name() helper Stephen Brennan
2026-10-02 9:12 ` sashiko-bot [this message]
2026-10-01 18:20 ` [PATCH 2/2] tools: perf: flamegraph.py: fix "Error reading report header" Stephen Brennan
2026-10-02 9:12 ` sashiko-bot
2026-10-02 5:24 ` [PATCH 0/2] perf script flamegraph: Fix input file name errors Ian Rogers
2026-10-02 18:27 ` Stephen Brennan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261002091258.49AED1F000FF@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
--cc=stephen.s.brennan@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox