From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BEFC44219F2 for ; Sun, 4 Oct 2026 10:26:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791109600; cv=none; b=hHrgnhYJKWe+he0R1UYVDZzKksYj7xIkCWlaC0w+l/zTsbVmJ9MhqlmjaUvIs99NUGcD9ZmBab1p6eRQYh6CGE6aYfVO9XbRqgVKxsn/DxzWB482lgaavDXrWZfQWszBzIUk7M0rwPmedzEAdBBX0sBj17fw4GWGDSF9OaGQNdw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791109600; c=relaxed/simple; bh=QNtvqcL5R+F8ytQPn9xtRmRNP59RQNomrgq4kFeOYuc=; h=From:Subject:To:Cc:In-Reply-To:References:Content-Type:Date: Message-Id; b=XSHWd3l9TvvBcL4e0JvrD1Gt2zFdfL/o3N4s/w5i5Os5S1n+CJrJBRNnaOXGxKepysqWiTV6AMOcvQXXgfscjz5oQuMMRDbqhc7NGEpuDuQPNR8hIlPHPa1tCHsQzYrkuoGnoVvGa8Kw7HW9wiYG+pkIG8d8WAX/wkL9h9QhEag= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=b8TmK/p/; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="b8TmK/p/" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4FC701F0089A; Sun, 4 Oct 2026 10:26:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1791109596; bh=c7OGacRi3a9M8ZPRPFu6oSEvVtBasXTZoqlDOdnc4cQ=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=b8TmK/p/iW18bICMxxA17qZoQxvHHZMKFUC+PykmTijScnVwWO3m6vg4K3jJoEW9P GeobEX4M0rD9Jy8JtNMOTldDmccps68JdTf5jOs0X6wdVeJw+P6DD10OhdwKVG/WuM yNTVsqL/ARTahEhlCqCaoy/pd5qdYlJq0+ipGE9GG0Sq26mnFA69knNol6CdGWSSsK 8UKpxHO7ZbQekvHMAMFjEoATIoQDtKsHtoBappGYfK5muebahaQ8nkbcoMm6ZP/kCq HuiEKg1jFkmIbTKaarKZ8Wq0fUSCKW4XHjyAmhlyi7YboaZczCFtC0kuTPVWYAPuXl 3S6gR3SKhP6ng== From: sashiko-bot@kernel.org Subject: Re: [PATCH v10 3/9] perf mutex: Add DEFINE_MUTEX() static initializer Reply-To: sashiko-reviews@lists.linux.dev To: "Arnaldo Carvalho de Melo" Cc: linux-perf-users@vger.kernel.org In-Reply-To: <20261004102133.26392-4-acme@kernel.org> References: <20261004102133.26392-1-acme@kernel.org> <20261004102133.26392-4-acme@kernel.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Sun, 04 Oct 2026 10:26:35 +0000 Message-Id: <20261004102636.4FC701F0089A@smtp.kernel.org> Precedence: bulk X-Mailing-List: linux-perf-users@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: > From: Arnaldo Carvalho de Melo >=20 > For file scope mutexes, so that they don't need a constructor function > to initialize them at startup, mirroring PTHREAD_MUTEX_INITIALIZER > while keeping the clang -Wthread-safety annotations of struct mutex. >=20 > DEBUG=3D1 builds have mutex_init() set PTHREAD_MUTEX_ERRORCHECK, making > the CHECK_ERR() paths in mutex_lock()/mutex_unlock() report relocking a > held mutex and unlocking one that isn't held. PTHREAD_MUTEX_INITIALIZER > gives a default type mutex, so statically initialized ones would silently > lose that: use PTHREAD_ERRORCHECK_MUTEX_INITIALIZER_NP, a glibc > extension, falling back to the default type in libcs that lack it. >=20 > Assisted-by: LLM > Signed-off-by: Arnaldo Carvalho de Melo Sashiko has reviewed this patch and found no issues. It looks great! --=20 Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20261004102133.2639= 2-1-acme@kernel.org?part=3D3