Re: [PATCH v2] perf trace: Support --bitmask-list with --libtraceevent

[sashiko-bot@kernel.org]

> Commit ab74d1fbe061 ("perf trace: Add --bitmask-list command-line option")
> introduced the --bitmask-list option to display cpumasks and bitmasks as
> condensed, human-readable range lists (e.g. "0,2-5,7") instead of the
> default hexadecimal format.
> 
> However, that implementation only augmented trace__fprintf_tp_fields().
> When --libtraceevent is specified, event formatting is delegated to
> event_format__fprintf(), which bypasses trace__fprintf_tp_fields() and
> relies directly on libtraceevent.
> 
> In libtraceevent, tracepoint bitmask fields defined using __get_bitmask()
> are parsed into TEP_PRINT_BITMASK AST nodes and unconditionally formatted
> as raw 32-bit hex chunks (e.g. "00000000,00000005"), ignoring the
> --bitmask-list command-line option.
> 
> [ ... ]
> recording replay (trace__replay()), leaving trace__event_handler()
> untouched. As with existing tracepoint replay in perf trace, this expects
> the evlist to be populated from the session header.
> 
> Signed-off-by: Aaron Tomlin <atomlin@atomlin.com>

Sashiko has reviewed this patch and found no issues. It looks great!

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261004121531.380660-1-atomlin@atomlin.com?part=1