From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AF96F363C53 for ; Sun, 4 Oct 2026 17:37:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791135435; cv=none; b=Lo7UZR2fjBzDTFVf25dN8V9mybTNrp4wpWo5UKYU+22SIFs4uB9uC8JS1A/WyibIkii4RGu7rlAn7rOrzXlg0G3BCP4tb0/9p0+DW6bjx0YXyuP152IW+KlPCrrY/IKExg2cl4Raq4e+0WGnqflgUVsCkMX+mjfblqqs7sbvArQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791135435; c=relaxed/simple; bh=brD7RIKC5TEosQb+0MusEBSzUcv4U7I3uZ7/vz5g3K4=; h=From:Subject:To:Cc:In-Reply-To:References:Content-Type:Date: Message-Id; b=XhOyT6IrLTnodexCGQkBw1fo6fqNb5TBib6xEqKFuytMDzgsQBeT8WbaN+A4UdmHytHK+SryOMbl4xoVg46r693mLJcQrhUPSv15yMo0fbRhmM6JIUkGCYtrY+zixSuKwwA08nwpue5xShpbMF/H2vyValIgS2ztnHdMKwBiKdQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=IuU7CnHp; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="IuU7CnHp" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3A84A1F000FF; Sun, 4 Oct 2026 17:37:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1791135434; bh=IUI2H5igQTtM2544k8sSSW/7+DIcfKHAryK8ukAshwA=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=IuU7CnHpJjxYXy3+w7JlTPTwJ2YDqm+xCuC7lrRW3bD+o+h0GZ/dHFmm+hDAFaQf7 G4Coap/DwEMS+ht65T2Rz0RwU05C2kNLQ8Ajnu3uTNj9FGEgWeXx68/RdmHW+kJaD8 B1uEUKTDbLbxiRid3MRyRmNwjFdD8+KrcGmTV5sRR79o5tNkfsLvKkLWpS6FosKO/M Vsh67yoO6kqHuDgjTbj8wbHsex6Ym4Cqh5PRfGJZezFSzyIAgBQKlEiILP0H7Aq6yH DE+uAOZwfWMssYIfxN3RWFuAmq+biUAgfQdOporg1kkndhwuNg2VlDtipreq+KO/C0 FR9VBht/5XYAg== From: sashiko-bot@kernel.org Subject: Re: [PATCH v11 6/9] perf report: Add --progress option Reply-To: sashiko-reviews@lists.linux.dev To: "Arnaldo Carvalho de Melo" Cc: linux-perf-users@vger.kernel.org In-Reply-To: <20261004173000.2863935-7-acme@kernel.org> References: <20261004173000.2863935-1-acme@kernel.org> <20261004173000.2863935-7-acme@kernel.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Sun, 04 Oct 2026 17:37:13 +0000 Message-Id: <20261004173714.3A84A1F000FF@smtp.kernel.org> Precedence: bulk X-Mailing-List: linux-perf-users@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: > From: Arnaldo Carvalho de Melo >=20 > Processing a large session with stdio output gives no feedback about > which phase perf is in or how far along it is: ui_progress updates are > only shown by the TUI. Add --progress, installing a stdio backend > (ui/stdio/progress.c) that prints the phase title, percentage and > counts: >=20 > Processing events... [ 42.3%] 317M / 746M >=20 > Phases can be nested, so the backend tracks the ones started to > complete the right one on ui_progress__finish(); that requires > init()/finish() pairs, fixed in ordered-events.c and the pipe and > directory event processing. >=20 > With a pager both stdout and stderr lead to it, so isatty(stderr) > turns false and the updates end up printed one per line in the > pager's output: use /dev/tty in that case, so that the updates keep > updating in place, untouched by the pager. >=20 > Assisted-by: LLM > Signed-off-by: Arnaldo Carvalho de Melo Sashiko has reviewed this patch and found no issues. It looks great! --=20 Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20261004173000.2863= 935-1-acme@kernel.org?part=3D6