Re: [PATCH v3 1/3] perf dwarf-aux: Add die_is_compound_type() to handle C++ class types

[sashiko-bot@kernel.org]

> Introduce the die_is_compound_type() helper which checks for
> DW_TAG_structure_type, DW_TAG_union_type, and DW_TAG_class_type, and
> convert the existing open-coded struct/union tag checks to use it:
> - die_get_member_type() in dwarf-aux.c.
> - is_compound_type() and set_stack_state() in annotate-data.c.
> 
> The switch in __add_member_cb() also handles unions and the nesting
> limit, so DW_TAG_class_type is just added there as another case.
> 
> Also accept DW_TAG_inheritance in the member lookup callbacks
> (__die_find_member_offset_cb() and __add_member_cb()) so that member
> lookup by offset descends into C++ base class subobjects.
> 
> In DWARF, a base class subobject is described by a DW_TAG_inheritance
> child of the derived class DIE.  It sits next to the DW_TAG_member
> [ ... ]
> This extends the existing member type resolution and data type
> profiling state handling to C++ classes with inheritance without
> changing behavior for C struct/union types.
> 
> Signed-off-by: Yanbo Zhao <yzhao62@ncsu.edu>

Sashiko has reviewed this patch and found no issues. It looks great!

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261005201010.36493-1-yzhao62@ncsu.edu?part=1