From: Steffen Eiden <seiden@linux.ibm.com>
To: Fuad Tabba <fuad.tabba@linux.dev>
Cc: Will Deacon <will@kernel.org>,
Catalin Marinas <catalin.marinas@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Marc Zyngier <maz@kernel.org>, Oliver Upton <oupton@kernel.org>,
Joey Gouly <joey.gouly@arm.com>,
Suzuki K Poulose <suzuki.poulose@arm.com>,
Zenghui Yu <yuzenghui@huawei.com>,
Mark Brown <broonie@kernel.org>, Fuad Tabba <tabba@google.com>,
linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev,
linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/4] arm64: sysreg: Mark fields the architecture dropped as RES0
Date: Thu, 15 Oct 2026 16:09:09 +0200 [thread overview]
Message-ID: <20261015140909.1310928-B-seiden@linux.ibm.com> (raw)
In-Reply-To: <20261013130247.4135515-4-fuad.tabba@linux.dev>
On Tue, Oct 13, 2026 at 02:02:46PM +0100, Fuad Tabba wrote:
> Commit d65bf6e317e7 ("KVM: arm64: Remove all traces of FEAT_TME")
> turned the TME fields of SCTLR_EL1 into RES0, but left their copies in
> SCTLRMASK_EL1. PMICFILTR_EL0.T and BRBFCR_EL1.LASTFAILED have gone from
> the architecture as well. All six fields are RES0 in DDI0601 2026-09.
>
> Mark them RES0 to match the spec. Nothing in the tree refers to them.
>
> Signed-off-by: Fuad Tabba <fuad.tabba@linux.dev>
Verified values with DDI0601 2026-09.
While checking I noticed that Bit 58 of PMICFILTR_EL0 is also defined as
RES0 in DDI0601 2026-09 but is defined as SYNC in tools/sysreg. Not sure
if this demands a separate patch or can be folded into this one as you
already are touching this reg. This field is unused as well.
Anyways,
Reviewed-by: Steffen Eiden <seiden@linux.ibm.com>
Steffen
> ---
> arch/arm64/tools/sysreg | 11 +++--------
> 1 file changed, 3 insertions(+), 8 deletions(-)
>
> diff --git a/arch/arm64/tools/sysreg b/arch/arm64/tools/sysreg
> index 341db8e9b6c37..99af1c39478be 100644
> --- a/arch/arm64/tools/sysreg
> +++ b/arch/arm64/tools/sysreg
> @@ -1420,8 +1420,7 @@ Field 17 DIRECT
> Field 16 EnI
> Res0 15:8
> Field 7 PAUSED
> -Field 6 LASTFAILED
> -Res0 5:0
> +Res0 6:0
> EndSysreg
>
> Sysreg BRBTS_EL1 2 1 9 0 2
> @@ -2663,11 +2662,7 @@ Field 57 EPAN
> Field 56 EnALS
> Field 55 EnAS0
> Field 54 EnASR
> -Field 53 TME
> -Field 52 TME0
> -Field 51 TMT
> -Field 50 TMT0
> -Res0 49:47
> +Res0 53:47
> Field 46 TWEDEL
> Field 45 TWEDEn
> Field 44 DSSBS
> @@ -2985,7 +2980,7 @@ Field 27 NSH
> Field 26 M
> Res0 25
> Field 24 SH
> -Field 23 T
> +Res0 23
> Field 22 RLK
> Field 21 RLU
> Field 20 RLH
> --
> 2.39.5
>
next prev parent reply other threads:[~2026-10-15 14:09 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-13 13:02 [PATCH 0/4] arm64: sysreg: Bring field definitions in line with the spec Fuad Tabba
2026-10-13 13:02 ` [PATCH 1/4] arm64: sysreg: Fix three incorrect enum values Fuad Tabba
2026-10-13 13:11 ` sashiko-bot
2026-10-13 13:49 ` Mark Brown
2026-10-13 13:02 ` [PATCH 2/4] arm64: sysreg: Fix the names of two misspelt fields Fuad Tabba
2026-10-13 13:09 ` sashiko-bot
2026-10-13 14:56 ` Mark Brown
2026-10-13 13:02 ` [PATCH 3/4] arm64: sysreg: Mark fields the architecture dropped as RES0 Fuad Tabba
2026-10-13 13:15 ` sashiko-bot
2026-10-13 13:27 ` Fuad Tabba
2026-10-15 14:09 ` Steffen Eiden [this message]
2026-10-15 14:12 ` Fuad Tabba
2026-10-13 13:02 ` [PATCH 4/4] perf: arm_brbe: Remove the check for TME transaction states Fuad Tabba
2026-10-13 13:13 ` sashiko-bot
2026-10-14 17:34 ` [PATCH 0/4] arm64: sysreg: Bring field definitions in line with the spec Catalin Marinas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261015140909.1310928-B-seiden@linux.ibm.com \
--to=seiden@linux.ibm.com \
--cc=broonie@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=fuad.tabba@linux.dev \
--cc=joey.gouly@arm.com \
--cc=kvmarm@lists.linux.dev \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=maz@kernel.org \
--cc=oupton@kernel.org \
--cc=suzuki.poulose@arm.com \
--cc=tabba@google.com \
--cc=will@kernel.org \
--cc=yuzenghui@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox