From: Namhyung Kim <namhyung@kernel.org>
To: Arnaldo Carvalho de Melo <acme@kernel.org>,
Ian Rogers <irogers@google.com>,
James Clark <james.clark@linaro.org>
Cc: Jiri Olsa <jolsa@kernel.org>,
Adrian Hunter <adrian.hunter@intel.com>,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
linux-perf-users@vger.kernel.org,
Sashiko <sashiko-bot@kernel.org>
Subject: [PATCH v2 4/5] perf symbol: Check result when reading section headers
Date: Sun, 18 Oct 2026 22:52:06 -0700 [thread overview]
Message-ID: <20261019055207.39325-5-namhyung@kernel.org> (raw)
In-Reply-To: <20261019055207.39325-1-namhyung@kernel.org>
Otherwise it may access uninitialized section header struct.
Reported-by: Sashiko <sashiko-bot@kernel.org>
Closes: https://lore.kernel.org/r/sashiko-outbox-170233@kernel.org
Signed-off-by: Namhyung Kim <namhyung@kernel.org>
---
tools/perf/util/symbol-elf.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/tools/perf/util/symbol-elf.c b/tools/perf/util/symbol-elf.c
index 1e2716c6af45712a..00ea0e19020fb256 100644
--- a/tools/perf/util/symbol-elf.c
+++ b/tools/perf/util/symbol-elf.c
@@ -196,13 +196,15 @@ Elf_Scn *elf_section_by_name(Elf *elf, GElf_Ehdr *ep,
while ((sec = elf_nextscn(elf, sec)) != NULL) {
char *str;
- gelf_getshdr(sec, shp);
+ if (!gelf_getshdr(sec, shp))
+ goto next;
str = elf_strptr(elf, ep->e_shstrndx, shp->sh_name);
if (str && !strcmp(name, str)) {
if (idx)
*idx = cnt;
return sec;
}
+next:
++cnt;
}
--
2.56.0
next prev parent reply other threads:[~2026-10-19 5:53 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-19 5:52 [PATCH v2 0/5] perf tools: Random fixes for the symbol code Namhyung Kim
2026-10-19 5:52 ` [PATCH v2 1/5] perf test: Fix a memory leak in PE file parsing test Namhyung Kim
2026-10-19 5:57 ` sashiko-bot
2026-10-19 5:52 ` [PATCH v2 2/5] perf test: Make sure maps to have a machine Namhyung Kim
2026-10-19 6:01 ` sashiko-bot
2026-10-19 5:52 ` [PATCH v2 3/5] perf tools: Remove NULL check for maps__machine() Namhyung Kim
2026-10-19 5:59 ` sashiko-bot
2026-10-19 5:52 ` Namhyung Kim [this message]
2026-10-19 5:57 ` [PATCH v2 4/5] perf symbol: Check result when reading section headers sashiko-bot
2026-10-19 5:52 ` [PATCH v2 5/5] perf symbol: Ensure dso__set_is_64_bit() for libbfd Namhyung Kim
2026-10-19 5:57 ` sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261019055207.39325-5-namhyung@kernel.org \
--to=namhyung@kernel.org \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=irogers@google.com \
--cc=james.clark@linaro.org \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=sashiko-bot@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox