From: Leo Yan <leo.yan@arm.com>
To: sashiko-reviews@lists.linux.dev
Cc: linux-perf-users@vger.kernel.org
Subject: Re: [PATCH] perf/aux: Avoid reclaim for optional higher-order allocations
Date: Mon, 9 Nov 2026 11:35:05 +0000 [thread overview]
Message-ID: <20261109113505.GX9176@e132581.arm.com> (raw)
In-Reply-To: <sashiko-outbox-204821@kernel.org>
On Mon, Nov 09, 2026 at 10:31:42AM +0000, sashiko-bot@kernel.org wrote:
[...]
> [Severity: Medium]
> This problem wasn't introduced by this patch, but can rb_alloc_aux() leak
> rb->aux_pages [1] when the first rb_alloc_aux_page() call fails? At
> that point rb->aux_nr_pages is still zero, and __rb_free_aux() only calls
> kfree(rb->aux_pages) when rb->aux_nr_pages is non-zero.
>
> [1] https://sashiko.dev/#/bug/linux-c1a2bb3b-5d2a-4fca-a697-ce07992a5cc1
See the patch that fixes this memory leak:
https://lore.kernel.org/lkml/20261109-perf_fix_aux_page_memleak-v1-1-aae781d6749c@arm.com/T/#u
prev parent reply other threads:[~2026-11-09 11:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-09 10:21 [PATCH] perf/aux: Avoid reclaim for optional higher-order allocations Leo Yan
2026-11-09 10:31 ` sashiko-bot
2026-11-09 11:35 ` Leo Yan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261109113505.GX9176@e132581.arm.com \
--to=leo.yan@arm.com \
--cc=linux-perf-users@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox