From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=74.125.82.197 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1794606608; b=iKZ7zwa0J7m5yLhib5jb0iH5ClfzlnRqoewTAsyLwFRxlT2Rqb0V8JJZ7o09b9RXQknK dhLv/OWb/LlZ6+yEhISv4bAfd0VIUSOngmuuYMCA2XCLc4sgiHqfhZr0AR5jdiS/3qZZo xOxSdrgdGFahICZUij2Nq7WUKWYKzIFzGeBRmvExltZ6Vnl9dTWUUpF5PyJfCbdxjiYFE nFZUeOwfSs0noby5pwEteG0OIribx5DFq1Cn8HA+FG6DtD0letKyNJnTRaXtP1lQ9/WyA o4nK4obm8nbJL8Efqlz0wdGVQ4eCotdOcDH5MeE0pfxdy+WKMykM4b+qdK5quNAHVYg== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1794606608; h=DMARC-Filter:Received:DKIM-Signature:X-Google-DKIM-Signature: X-Forwarded-Encrypted:X-Gm-Message-State:X-Received:Date:In-Reply-To: Mime-Version:References:X-Mailer:Message-ID:Subject:From:To:Cc: Content-Type; bh=hA1HAfb/QSQMHgzacElngcaBrHbu0zBHzLVSIBZt9mI=; b=aM/wDAuRltlWGyN1UNoK6aJmwAMJgI6p9K1/pAOINyRFaqkakRngrhSdJQvHlTO8O22v NnFvU+Cu7OaFWUBL1WU5GPfk0mzF/6YIRrsnEvi2kgI32ICUfffoyzNdwuDXtxgxazVVk ialaQrNgHDgZ031JR4q1gsdbIDxS/SmRHmjY6F8QYoOiSdbOLzd7b77+CECPub6AI9B3D wJ4lnlbnNJhfTtVVA+ZIV0gZLlGcklXpzgqZhFSvq4mmt+5D8LFnANZwTzDs5HwDVONjV 9YKPxp9PTxDvBElHOm3tzoVOOEzxOecLPfuse012IIxSNC/9cXlO7Nb96/vy43RNC3A== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=google.com; spf=pass smtp.mailfrom=flex--irogers.bounces.google.com; dkim=pass header.d=google.com header.i=@google.com header.a=rsa-sha256 header.s=20260707 header.b=Qq3W5meK; arc=none smtp.remote-ip=74.125.82.197 Received: from mail-dy1-f197.google.com (mail-dy1-f197.google.com [74.125.82.197]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9BE96606C9B5 for ; Fri, 13 Nov 2026 21:50:05 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 9BE96606C9B5 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--irogers.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.a=rsa-sha256 header.s=20260707 header.b=Qq3W5meK Received: by mail-dy1-f197.google.com with SMTP id 5a478bee46e88-36f479b9819so1687612eec.1 for ; Fri, 13 Nov 2026 13:50:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20260707; t=1794606605; x=1795211405; darn=vger.kernel.org; h=content-type:cc:to:from:subject:message-id:references:mime-version :in-reply-to:date:from:to:cc:subject:date:message-id:reply-to :content-type; bh=hA1HAfb/QSQMHgzacElngcaBrHbu0zBHzLVSIBZt9mI=; b=Qq3W5meKcq2l47T+ofNmtIuEs/vCfyKoUtPqzHoUJHMciixy/WK6X/6oEryGTCfziI HZwjhqytMbycgWuCOJikgiJHC3aeT0yGD+C4tWElMjxuYLrdI6VpZLMO6UW+pZx3TIHp 4u4qwDNloNP3FRNCiushvWtVxNN/HJAIkbqCpJuxBaedMswm0JxanfmDa02VlMIDlqBT FOr/hvjZySw2GJoexwged/zJ0kQOZMg1h5IiuFsuMyPQSYLJ0yMXKWcz7BhtW8Ii7F+e O9rvZ7nvXWQn81oUL4RQFTTxqgbcvrUrp8aQqWy0Nc8OOBUYXPsW4C+EbUGOVSVLoIFJ RIAw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1794606605; x=1795211405; h=content-type:cc:to:from:subject:message-id:references:mime-version :in-reply-to:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=hA1HAfb/QSQMHgzacElngcaBrHbu0zBHzLVSIBZt9mI=; b=IedjoVOpPQ95rBi+vrDS+50AC/pK+M+gvPjTbf5tsiHFVlpwU++qOrVoL/ic7yMdb7 y77NqAbNuXuhj81KQ+2GxitYurffQAhEyQJaABhm8V23FKxz9d9X/h6TD1UDvlMk2CRF 5C/DmbibpDGifutkcHYk8/Mpmbr45hlduN0iLUB/BmBxTwFsbdkImrNZ1Yp9gKJXMPHB J2OBdZirN7dp1oF4a8md778UNOn4efzXtle56dtuNRx267sq/p9SxDImM/s5UJIdNWhB Sp66zMxzrg+Ef0ehtKTMBnqF4f7AWsA7gVr5Cv/MiWfINb+BOf2ge4BAz5eqZGD8fIHP vlUQ== X-Forwarded-Encrypted: i=1; AL+hErGKnNH4ImbmuFc1KcIwPA2Lx/+zbMnKmMI4TGIRXNRpeVJ+PBXgQ2GsCVgaPzy8yzny2UR5xha/WwfnLm/AoWoI@vger.kernel.org X-Gm-Message-State: APuU4Z+D/f06UP2aq5dSb43ZqZWzdt+psA4r1hl/CCk9RGTCvz2OKkeE 6TiRekcslO2ySmJib4hapVF3FMY/1i5i+lNGzYYkfMjMPZscPoEX6dvszMmp57kNzmR+nOFKt8B 1vMyrfbGvzQ== X-Received: from dlae24.prod.google.com ([2002:a05:701b:2318:b0:18c:3061:3bca]) (user=irogers job=prod-delivery.src-stubby-dispatcher) by 2002:a05:7022:3c01:b0:1a7:7160:ffc8 with SMTP id a92af1059eb24-1b5030982b9mr3101249c88.10.1794606604623; Fri, 13 Nov 2026 13:50:04 -0800 (PST) Date: Fri, 13 Nov 2026 13:48:44 -0800 In-Reply-To: <20261113214850.3329699-1-irogers@google.com> X-Mailing-List: linux-perf-users@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list Mime-Version: 1.0 References: <20261113214850.3329699-1-irogers@google.com> X-Mailer: git-send-email 2.56.1.703.gf848ed807c-goog Message-ID: <20261113214850.3329699-21-irogers@google.com> Subject: [PATCH v1 20/26] perf annotate: Use generic hashmap for sym_samples From: Ian Rogers To: Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Namhyung Kim Cc: Jiri Olsa , Ian Rogers , Adrian Hunter , James Clark , linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Convert annotated_source::samples in util/annotate.{c,h} to DECLARE_HASHMAP(sym_samples_map, long, struct sym_hist_entry *) and use hashmap__for_each() when freeing histogram entries. Signed-off-by: Ian Rogers --- tools/perf/util/annotate.c | 20 ++++++++++---------- tools/perf/util/annotate.h | 5 ++++- 2 files changed, 14 insertions(+), 11 deletions(-) diff --git a/tools/perf/util/annotate.c b/tools/perf/util/annotate.c index d11add6424dc..c6325040452f 100644 --- a/tools/perf/util/annotate.c +++ b/tools/perf/util/annotate.c @@ -112,16 +112,16 @@ static struct annotated_source *annotated_source__new(void) static __maybe_unused void annotated_source__delete(struct annotated_source *src) { - struct hashmap_entry *cur; - size_t bkt; + long key; + struct sym_hist_entry *val; if (src == NULL) return; if (src->samples) { - hashmap__for_each_entry(src->samples, cur, bkt) - zfree(&cur->pvalue); - hashmap__free(src->samples); + hashmap__for_each(src->samples, key, val) + free(val); + sym_samples_map__free(src->samples); } zfree(&src->histograms); free(src); @@ -136,7 +136,7 @@ static int annotated_source__alloc_histograms(struct annotated_source *src, if (src->histograms == NULL) return -1; - src->samples = hashmap__new(sym_hist_hash, sym_hist_equal, NULL); + src->samples = sym_samples_map__new(sym_hist_hash, sym_hist_equal, NULL); if (!src->samples) zfree(&src->histograms); @@ -163,11 +163,11 @@ void symbol__annotate_zero_histograms(struct symbol *sym) memset(notes->src->histograms, 0, notes->src->nr_histograms * sizeof(*notes->src->histograms)); if (notes->src->samples) { - struct hashmap_entry *cur; - size_t bkt; + long key; + struct sym_hist_entry *val; - hashmap__for_each_entry(notes->src->samples, cur, bkt) - zfree(&cur->pvalue); + hashmap__for_each(notes->src->samples, key, val) + free(val); hashmap__clear(notes->src->samples); } } diff --git a/tools/perf/util/annotate.h b/tools/perf/util/annotate.h index 1b47c1156b9a..495c8602864c 100644 --- a/tools/perf/util/annotate.h +++ b/tools/perf/util/annotate.h @@ -312,10 +312,13 @@ struct cyc_hist { * presented. It is deallocated right after symbol__{tui,tty,etc}_annotate * returns. */ +struct sym_hist_entry; +DECLARE_HASHMAP(sym_samples_map, long, struct sym_hist_entry *); + struct annotated_source { struct list_head source; struct sym_hist *histograms; - struct hashmap *samples; + struct sym_samples_map *samples; int nr_histograms; int nr_events; int nr_entries; -- 2.56.1.703.gf848ed807c-goog