From: Peter Zijlstra <peterz@infradead.org>
To: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Cc: Tengda Wu <wutengda@huaweicloud.com>,
Ingo Molnar <mingo@redhat.com>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Namhyung Kim <namhyung@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@kernel.org>, Ian Rogers <irogers@google.com>,
Adrian Hunter <adrian.hunter@intel.com>,
James Clark <james.clark@linaro.org>,
linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5 1/2] perf/core: Prevent duplicate sigtrap task work enqueue
Date: Fri, 20 Nov 2026 16:24:55 +0100 [thread overview]
Message-ID: <20261120152455.GV2668564@noisy.programming.kicks-ass.net> (raw)
In-Reply-To: <20261120151017.mKJ_Y_u0@linutronix.de>
On Fri, Nov 20, 2026 at 04:10:17PM +0100, Sebastian Andrzej Siewior wrote:
> On 2026-11-20 16:04:52 [+0100], Peter Zijlstra wrote:
> > On Fri, Nov 20, 2026 at 03:16:06PM +0100, Sebastian Andrzej Siewior wrote:
> > > On 2026-11-20 13:14:36 [+0100], Peter Zijlstra wrote:
> > > > > Also use smp_load_acquire() when checking pending_work in
> > > > > the exclude_kernel warning path to ensure the read is properly
> > > > > ordered.
> > > >
> > > > I am confused by the use of smp_*() and cmpxchg() here. Where is the
> > > > multi-cpu scenario?
> > >
> > > The same event is used in process context and NMI
> > > | perf-tc1-7647 [001] d..6. 114.513688: __perf_event_overflow: ffff888100d68540
> > > | perf-tc1-7647 [001] d.Z2. 114.513703: __perf_event_overflow: ffff888100d68540
> > >
> > > I don't see how to deal with this without cmpxchg. And the same event is
> > > also used by other task
> >
> > You can do CMPXCHG (without the LOCK) prefix; the helper is called
> > cmpxchg_local().
> >
> > > | perf-tc1-7657 [001] d.Z2. 114.598356: __perf_event_overflow: ffff888100d68540
> > >
> > > which makes me thing that it could be pinned to another CPU (unless
> > > there is something that impossible and it is strictly per-CPU).
> > >
> > > The smp load/store macros is my fault as it looked better to do this
> > > than plain stores (given that we have the cmpxchg already).
> >
> > It is confusing as all heck. This is all task-local, and a task can only
> > ever run on one CPU at the time.
>
> Given the two pids I was assuming (!knowing) that two CPUs could be
> involved.
>
> So you are saying cmpxchg_local() and a plain assign/WRITE_ONCE rather
> than the smp.* given that this is all task local.
Well, from what I can remember, only task bound self-monitoring events
can signal, and the whole task_work is per necessity task local. Which
makes it all local.
It is indeed {READ,WRITE}_ONCE() combined with barrier() if you really
need to beat the compiler into submission.
But let me go try and read this Changelog in more detail.
next prev parent reply other threads:[~2026-11-20 15:25 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-19 9:50 [PATCH v5 0/2] perf/core: Fix sigtrap task_work races Tengda Wu
2026-11-19 9:51 ` [PATCH v5 1/2] perf/core: Prevent duplicate sigtrap task work enqueue Tengda Wu
2026-11-19 9:59 ` sashiko-bot
2026-11-19 12:09 ` Sebastian Andrzej Siewior
2026-11-20 12:14 ` Peter Zijlstra
2026-11-20 14:16 ` Sebastian Andrzej Siewior
2026-11-20 15:04 ` Peter Zijlstra
2026-11-20 15:10 ` Sebastian Andrzej Siewior
2026-11-20 15:24 ` Peter Zijlstra [this message]
2026-11-20 15:44 ` Peter Zijlstra
2026-11-20 15:49 ` Sebastian Andrzej Siewior
2026-11-19 9:51 ` [PATCH v5 2/2] perf/core: Disable context fast-swap for sigtrap events Tengda Wu
2026-11-19 10:03 ` sashiko-bot
2026-11-19 11:39 ` Tengda Wu
2026-11-19 12:11 ` Sebastian Andrzej Siewior
2026-11-19 12:17 ` Tengda Wu
2026-11-19 13:07 ` Sebastian Andrzej Siewior
2026-11-19 13:19 ` Tengda Wu
2026-11-19 13:48 ` Sebastian Andrzej Siewior
2026-11-20 0:55 ` Tengda Wu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261120152455.GV2668564@noisy.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=bigeasy@linutronix.de \
--cc=irogers@google.com \
--cc=james.clark@linaro.org \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=wutengda@huaweicloud.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox