From: Ian Rogers <irogers@google.com>
To: Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Namhyung Kim <namhyung@kernel.org>,
Marco Elver <elver@google.com>
Cc: Bart Van Assche <bvanassche@acm.org>,
Jiri Olsa <jolsa@kernel.org>,
Adrian Hunter <adrian.hunter@intel.com>,
James Clark <james.clark@linaro.org>,
Weilin Wang <weilin.wang@intel.com>,
Nathan Chancellor <nathan@kernel.org>,
Nick Desaulniers <ndesaulniers@google.com>,
Bill Wendling <morbo@google.com>,
Justin Stitt <justinstitt@google.com>,
linux-perf-users@vger.kernel.org, llvm@lists.linux.dev,
bpf@vger.kernel.org, linux-kernel@vger.kernel.org,
Ian Rogers <irogers@google.com>
Subject: [PATCH v15 19/23] perf maps: Remove unused maps__load_first()
Date: Fri, 20 Nov 2026 22:58:08 -0800 [thread overview]
Message-ID: <20261121065813.4143649-20-irogers@google.com> (raw)
In-Reply-To: <20261121065813.4143649-1-irogers@google.com>
Commit 553d18c98a89 ("perf lock contention: Load kernel map before
lookup") removed the last caller of maps__load_first(). Remove the
unused function and its declaration.
Signed-off-by: Ian Rogers <irogers@google.com>
---
tools/perf/util/maps.c | 10 ----------
tools/perf/util/maps.h | 2 --
2 files changed, 12 deletions(-)
diff --git a/tools/perf/util/maps.c b/tools/perf/util/maps.c
index 675fe0223faa..496a592284c5 100644
--- a/tools/perf/util/maps.c
+++ b/tools/perf/util/maps.c
@@ -1457,13 +1457,3 @@ int maps__merge_in(struct maps *kmaps, struct map *new_map)
up_write(maps__lock(kmaps));
return 0;
}
-
-void maps__load_first(struct maps *maps)
-{
- down_read(maps__lock(maps));
-
- if (maps__nr_maps(maps) > 0)
- map__load(maps__maps_by_address(maps)[0]);
-
- up_read(maps__lock(maps));
-}
diff --git a/tools/perf/util/maps.h b/tools/perf/util/maps.h
index 4ec9b7453a3b..4e6eff244125 100644
--- a/tools/perf/util/maps.h
+++ b/tools/perf/util/maps.h
@@ -83,6 +83,4 @@ int maps__merge_in(struct maps *kmaps, struct map *new_map);
void maps__fixup_end(struct maps *maps);
-void maps__load_first(struct maps *maps);
-
#endif // __PERF_MAPS_H
--
2.56.1.750.gf70dc682cf-goog
next prev parent reply other threads:[~2026-11-21 6:59 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-21 6:57 [PATCH v15 00/23] tools/perf: Adopt kernel compiler-context-analysis.h annotations Ian Rogers
2026-11-21 6:57 ` [PATCH v15 01/23] compiler-context-analysis: Avoid unused parameter warning in _context_unsafe_alias() Ian Rogers
2026-11-21 6:57 ` [PATCH v15 02/23] tools headers compiler: Synchronize compiler_types.h with the kernel sources Ian Rogers
2026-11-21 6:57 ` [PATCH v15 03/23] tools headers: Synchronize linux/compiler-context-analysis.h " Ian Rogers
2026-11-21 6:57 ` [PATCH v15 04/23] perf mutex: Use kernel style compiler-context-analysis.h annotations Ian Rogers
2026-11-21 6:57 ` [PATCH v15 05/23] perf build: Enable context analysis and Clang thread-safety flags Ian Rogers
2026-11-21 6:57 ` [PATCH v15 06/23] perf comm: Add __guarded_by annotations to struct comm_strs Ian Rogers
2026-11-21 6:57 ` [PATCH v15 07/23] perf vdso: Fix unlocked __dsos__add() and race in __machine__addnew_vdso() Ian Rogers
2026-11-21 6:57 ` [PATCH v15 08/23] perf dsos: Skip BPF and OOL DSOs in dsos__find_kernel_dso() Ian Rogers
2026-11-21 6:57 ` [PATCH v15 09/23] perf dsos: Ensure DSOs in auxtrace, machine, and symbol are in dsos Ian Rogers
2026-11-21 6:57 ` [PATCH v15 10/23] perf dso: Pass dso_data to close_data_fd() and dso__list_del() Ian Rogers
2026-11-21 6:58 ` [PATCH v15 11/23] perf dso: Use DEFINE_MUTEX for dso__data_open_lock Ian Rogers
2026-11-21 6:58 ` [PATCH v15 12/23] perf dsos: Use read lock fast path in dsos__findnew_id() Ian Rogers
2026-11-21 6:58 ` [PATCH v15 13/23] perf dso: Expand context analysis annotations Ian Rogers
2026-11-21 6:58 ` [PATCH v15 14/23] perf thread: Expand context analysis annotations to threads and namespaces_lock Ian Rogers
2026-11-21 6:58 ` [PATCH v15 15/23] perf intel-tpebs: Fix race in tpebs_stop() and tpebs_cmd.out fd handling Ian Rogers
2026-11-21 6:58 ` [PATCH v15 16/23] perf intel-tpebs: Use DEFINE_MUTEX for tpebs_mtx and add lock annotations Ian Rogers
2026-11-21 6:58 ` [PATCH v15 17/23] perf config: Add __guarded_by and __must_hold annotations Ian Rogers
2026-11-21 6:58 ` [PATCH v15 18/23] perf env: " Ian Rogers
2026-11-21 6:58 ` Ian Rogers [this message]
2026-11-21 6:58 ` [PATCH v15 20/23] perf maps: Fix map index lookup fallback and removal Ian Rogers
2026-11-21 6:58 ` [PATCH v15 21/23] perf maps: Add context analysis annotations Ian Rogers
2026-11-21 6:58 ` [PATCH v15 22/23] perf machine: Hold machines->lock for remaining guests rbtree accesses Ian Rogers
2026-11-21 6:58 ` [PATCH v15 23/23] perf machine: Add __guarded_by annotation to machines->guests Ian Rogers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261121065813.4143649-20-irogers@google.com \
--to=irogers@google.com \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=bpf@vger.kernel.org \
--cc=bvanassche@acm.org \
--cc=elver@google.com \
--cc=james.clark@linaro.org \
--cc=jolsa@kernel.org \
--cc=justinstitt@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=llvm@lists.linux.dev \
--cc=mingo@redhat.com \
--cc=morbo@google.com \
--cc=namhyung@kernel.org \
--cc=nathan@kernel.org \
--cc=ndesaulniers@google.com \
--cc=peterz@infradead.org \
--cc=weilin.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox