From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f46.google.com (mail-wm1-f46.google.com [209.85.128.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 58E193491C2 for ; Thu, 23 Apr 2026 09:13:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.46 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776935607; cv=none; b=nj1NGL8umDBO00Jxw62hRJI1JSyHUZE45jORJ30wyqsknKU9D/0uAfm5LPdvz114uVHMG7jGdf3z9UB3MEC/k49N5P4rJi9MsfgbWLgzFi1KvfER3/XHocH/IcRldFV18tPOWOOplP7crhEt0c/8ohKr6afSVmtUqej4RrKIWmA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776935607; c=relaxed/simple; bh=6T9IqlK5280psLkT3eMJmwYwDyICLVpbc7WfYWRFFiY=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=t3+jXdEFRFCjsNBK4OJ3U+QuEgIrJWFhMU1c2BMKA5RPxLHg98CbIuDAwodiOymlRDQ90JQpSKhExSzBRaNpFj5GHDlnt6Zhbb9EVtvU4qUFPpXIcwTJ1JnttlfUbVUPsOn/j6/5+8/PtBse8GbyoG5p9X8CTyhRwdMV/79JNkQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=sGuGzt8O; arc=none smtp.client-ip=209.85.128.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="sGuGzt8O" Received: by mail-wm1-f46.google.com with SMTP id 5b1f17b1804b1-488af96f6b2so82357925e9.0 for ; Thu, 23 Apr 2026 02:13:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1776935605; x=1777540405; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=iBZ9+FXv0tBiNwFRrrrMnD/CIzl1HaptSL4qAqgrjwM=; b=sGuGzt8OSxXHXuuQSOIbjM0yAZHsXrcsBG0ct0RqXYUgZDL2Md8h1h01TBdRYMtvJS gSAaBP/bBElP+I5fQ6XuYMCp1nSzXOO7/Sd1dmQAq5eHd+FCd3RqF8jIm3btI1DR6zbS BcLa3rrvHBebrEiaQbO5nVi8uDxEM+NvnqvPZ/TefJGvJWAudWHRWkVrgmNrxSAI2fLr 0drhLCZA5yE7oaS6+d3GRSTMsEAshwGQX6Znhgt5y9jYTN4M9aYO94GWekxeUo/17rqY 3BuxbiqaZLIpp6JLklQygli7DWihQLEVrspiYmCddhwJX3XNjfNyAWbVaMD8QY3LMB+y Vqig== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776935605; x=1777540405; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=iBZ9+FXv0tBiNwFRrrrMnD/CIzl1HaptSL4qAqgrjwM=; b=bhq5nIFmKBxh829XtlVmXCrtsCyajrj2lLASbx87H8wizz0xecXYeiMsRoau6NBoDI yRV8uaquYrtmObaH0vDzqAIrP6+3e7k3t+15/RjHNnSAtbWunPIHjgfY1a1yh0O6IAlX rwRWkzaLfZQlV/IKAa9i2OlqsDPBk/dy2ks/s+goCA848IrUuKgsc9Xb4uJNDru4aDne zjfd3sd0LJGxDFU+Lbz8s/bI2tf9Dt/WtztTTvFNybv0v/SNCsjneU4vW26u++SrJSf0 xabKfG8xvonfjRHkF07wE33pndsy4SUEJbUhJTkOsHHMXKZwh2H84+R3Bw/d90E4xrFY mgtA== X-Forwarded-Encrypted: i=1; AFNElJ9AqSb657Vt41gRd5ZLaqz4jhJttn7ha89dSbd1QxWY1gVzgH8Q1Wb6f+gnj96iPw/3RSPwMWJq5gzTquQKJ3J1@vger.kernel.org X-Gm-Message-State: AOJu0YxmiMuLiGceFVyAtA74kpGwXo7v7YyFg5sh79uc59NMAQaNT+NN 3wmkezu4bKmiMHWzS3QCl7JmvfhbwAC0KqBv7tBQ26IRPwhTmhHGNi68zgaQ+P23zH7e1JvNUxb SewX/XyBlgQ== X-Gm-Gg: AeBDieuLD33TGmYuF1YB+YzkNy9rmcMFVHF0Q+WZX9bCVFsEW5X4v9a+rHCiOEa7zht 2jAJsCKNJApiZpmkwL8Cqs/DI8gPFNXPIvVkt0AjwYsThFn4toq1eVo6ai7+lUifutIruPGgd0q iq+/SYDbEQ1rLob+Mg7hqOD3u2SJYseBPH3mR+s4Sl9i6HasGF+MQVFhgTzXaeJ4+w9oG+Z3Ov4 t1EDGsIathDgMHd/2ywkc8vee1bKE36xxV5SWB52IilLFxEjLSY4hrD/eEcTCdL8HpSnOtGe5kp EAGm4irP1DHYA9X+Dte8aeVmqkwzPMo41jBkYoxO+PkwQ4G3RCTTl7k/UH7t/WVLb7Wuye7+fv6 GTbjK71hMvRPjhz7CQedTpHrghgT8rnGlrhNWymKS6a9+PMlk9C3CJfK6Ag/WFJTT4EtGdYdK4I s7hwkTkQ/TSuOjuObNFzXuu8ejrCXbyQGhs1A182gZv6E= X-Received: by 2002:a05:600c:c10a:b0:483:2c98:4368 with SMTP id 5b1f17b1804b1-488fb771613mr293409705e9.18.1776935604727; Thu, 23 Apr 2026 02:13:24 -0700 (PDT) Received: from [192.168.178.64] ([84.246.200.167]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48a557412eesm85745545e9.9.2026.04.23.02.13.22 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 23 Apr 2026 02:13:24 -0700 (PDT) Message-ID: <204607f3-16fc-4be8-91ac-bf38c6dc31f9@linaro.org> Date: Thu, 23 Apr 2026 10:13:22 +0100 Precedence: bulk X-Mailing-List: linux-perf-users@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] perf dwarf-regs: Fix off by one in __get_dwarf_regnum_for_perf_regnum_csky() To: Dan Carpenter , Ian Rogers Cc: Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Namhyung Kim , Mark Rutland , Alexander Shishkin , Jiri Olsa , Adrian Hunter , Guo Ren , linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org, linux-csky@vger.kernel.org, kernel-janitors@vger.kernel.org References: Content-Language: en-US From: James Clark In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 23/04/2026 08:00, Dan Carpenter wrote: > Change the > comparison >= to prevent an out of bounds access of > the dwarf_csky_regnumsp[] array. > > Fixes: 8cac4013b0c2 ("perf dwarf-regs: Add csky perf to dwarf register number mapping functions") > Signed-off-by: Dan Carpenter > --- > --- > tools/perf/util/dwarf-regs-arch/dwarf-regs-csky.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tools/perf/util/dwarf-regs-arch/dwarf-regs-csky.c b/tools/perf/util/dwarf-regs-arch/dwarf-regs-csky.c > index cb44b774f8d9..4c586a5cb763 100644 > --- a/tools/perf/util/dwarf-regs-arch/dwarf-regs-csky.c > +++ b/tools/perf/util/dwarf-regs-arch/dwarf-regs-csky.c > @@ -118,7 +118,7 @@ int __get_dwarf_regnum_for_perf_regnum_csky(int perf_regnum, unsigned int flags) > if (flags & EF_CSKY_ABIV2) > idx++; > > - if (perf_regnum < 0 || perf_regnum > (int)ARRAY_SIZE(dwarf_csky_regnums) || > + if (perf_regnum < 0 || perf_regnum >= (int)ARRAY_SIZE(dwarf_csky_regnums) || > dwarf_csky_regnums[perf_regnum][idx] == 0) > return -ENOENT; > Reviewed-by: James Clark