From: Dan Carpenter <dan.carpenter@linaro.org>
To: Frederic Weisbecker <frederic@kernel.org>
Cc: Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
Peter Zijlstra <peterz@infradead.org>,
linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [bug report] perf: Fix event leak upon exec and file release
Date: Wed, 2 Oct 2024 17:57:32 +0300 [thread overview]
Message-ID: <2391f501-6d4d-44f8-ae81-c9bbef9a35ee@stanley.mountain> (raw)
In-Reply-To: <Zv1P7UzPWvFjOupc@localhost.localdomain>
On Wed, Oct 02, 2024 at 03:51:41PM +0200, Frederic Weisbecker wrote:
> So this should be fine (famous last words). There is a might_sleep() call in
> irq_work_sync() that should tell us about it.
Thanks for looking at this, Frederic.
I don't know that the might_sleep() helps us very much... In my experience very
few people know about or enable CONFIG_DEBUG_ATOMIC_SLEEP. It used to be much
more common to enable this back in the day. Twenty years ago Linux kernels
would deadlock more often than they do now. Lockdep and static checkers have
helped a lot. People back then only had one processor so sleeping in atomic
would lead lead to deadlocks more often than it does now where the kernel can
reschedule the sleeping task on a different CPU.
With the realtime kernel, I kind of expect sleeping in atomic to become a common
bug for a while so probably people should start enabling it again.
regards,
dan carpenter
prev parent reply other threads:[~2024-10-02 14:57 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-23 13:43 [bug report] perf: Fix event leak upon exec and file release Dan Carpenter
2024-09-02 21:47 ` Frederic Weisbecker
2024-09-30 9:04 ` Sebastian Andrzej Siewior
2024-10-02 13:51 ` Frederic Weisbecker
2024-10-02 14:57 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2391f501-6d4d-44f8-ae81-c9bbef9a35ee@stanley.mountain \
--to=dan.carpenter@linaro.org \
--cc=bigeasy@linutronix.de \
--cc=frederic@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox