From: Vineet Gupta <vgupta@kernel.org>
To: Alexey Brodkin <Alexey.Brodkin@synopsys.com>,
linux-snps-arc@lists.infradead.org
Cc: linux-perf-users@vger.kernel.org,
Stephen Rothwell <sfr@canb.auug.org.au>,
Mischa Jonker <Mischa.Jonker@synopsys.com>,
Vineet Gupta <vgupta@kernel.org>
Subject: Re: [PATCH] arc: perf: Move static structs to where they're really used
Date: Tue, 28 Dec 2021 19:47:06 -0800 [thread overview]
Message-ID: <23a16eb8-ccbe-e000-53a4-0b0dc2ffb1ad@kernel.org> (raw)
In-Reply-To: <20211129203707.28510-1-abrodkin@synopsys.com>
On 11/29/21 12:37 PM, Alexey Brodkin wrote:
> It is all well described by Stephen Rothwell who initially spotted that:
> ----------------------------->8----------------------------
> After merging the origin tree, today's linux-next build (arc
> haps_hs_smp_defconfig+kselftest) produced these warnings:
>
> arch/arc/include/asm/perf_event.h:126:27: warning: 'arc_pmu_cache_map' defined but not used [-Wunused-const-variable=]
> arch/arc/include/asm/perf_event.h:91:27: warning: 'arc_pmu_ev_hw_map' defined but not used [-Wunused-const-variable=]
>
> Introduced by commit 0dd450fe13da ("ARC: Add perf support for ARC700 cores")
>
> The 2 static arrays should be moved into arch/arc/kernel/perf_event.c
> (the only place that uses them). We get the warning because perf_event.h
> is also included by arch/arc/kernel/unaligned.c.
> ----------------------------->8----------------------------
>
> Could be easily reproduced by running make with "W=1" on any up-to-date
> sources, when extra warnings get enabled (in particular
> "-Wunused-const-variable"), otherwise disabled by default in the top-level
> Makefile as "These warnings generated too much noise in a regular build".
>
> Signed-off-by: Alexey Brodkin<abrodkin@synopsys.com>
> Cc: Stephen Rothwell<sfr@canb.auug.org.au>
> Cc: Mischa Jonker<mjonker@synopsys.com>
> Cc: Vineet Gupta<vgupta@kernel.org>
Added to ARC tree.
Thx,
-Vineet
prev parent reply other threads:[~2021-12-29 3:47 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-29 20:37 [PATCH] arc: perf: Move static structs to where they're really used Alexey Brodkin
2021-12-29 3:47 ` Vineet Gupta [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=23a16eb8-ccbe-e000-53a4-0b0dc2ffb1ad@kernel.org \
--to=vgupta@kernel.org \
--cc=Alexey.Brodkin@synopsys.com \
--cc=Mischa.Jonker@synopsys.com \
--cc=linux-perf-users@vger.kernel.org \
--cc=linux-snps-arc@lists.infradead.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).