From: Oleksandr Natalenko <oleksandr@natalenko.name>
To: Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@kernel.org>, Namhyung Kim <namhyung@kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
Borislav Petkov <bp@alien8.de>,
Dave Hansen <dave.hansen@linux.intel.com>,
hpa@zytor.com, Stephane Eranian <eranian@google.com>,
Wyes Karny <wyes.karny@amd.com>
Cc: x86@kernel.org, linux-perf-users@vger.kernel.org,
linux-kernel@vger.kernel.org, gautham.shenoy@amd.com,
ananth.narayan@amd.com,
Muhammad Usama Anjum <usama.anjum@collabora.com>,
Wyes Karny <wyes.karny@amd.com>
Subject: Re: [RFC PATCH v2 0/2] Enable Core RAPL for AMD
Date: Thu, 02 Mar 2023 20:45:47 +0100 [thread overview]
Message-ID: <2670154.mvXUDI8C0e@natalenko.name> (raw)
In-Reply-To: <20230301181449.14647-1-wyes.karny@amd.com>
Hello.
On středa 1. března 2023 19:14:47 CET Wyes Karny wrote:
> This is v2 patch set for enabling per-core RAPL counters through
> energy-cores event on RAPL PMU. Added RFC tag because a new patch is
> added and this additional patch may need clarification from the
> community.
>
> While enabling this support with v1 patch [1], Stephane reported an
> issue where for the first reading of energy-cores event for every core was
> invalid [2]. This issue is addressed with patch 1 of this series. There
> is no change in patch 2.
>
> [1]: https://lore.kernel.org/lkml/20230217161354.129442-1-wyes.karny@amd.com/
> [2]: https://lore.kernel.org/lkml/CABPqkBQ_bSTC-OEe_LrgUrpj2VsseX1ThvO-yLcEtF8vb4+AAw@mail.gmail.com/
>
> Change log:
> v1 -> v2:
> - Added new patch to fix the issue reported by Stephane
> - Added RFC tag
>
> Wyes Karny (2):
> perf/x86/rapl: Fix energy-cores event
> perf/x86/rapl: Enable Core RAPL for AMD
>
> arch/x86/events/rapl.c | 20 +++++++++++++++-----
> 1 file changed, 15 insertions(+), 5 deletions(-)
Since I was asked to re-test v2:
```
$ sudo perf stat -a --per-core -C 0-15 -e power/energy-cores/ -- dd if=/dev/zero of=/dev/null bs=1M count=1000000
1000000+0 records in
1000000+0 records out
1048576000000 bytes (1,0 TB, 977 GiB) copied, 17,0321 s, 61,6 GB/s
Performance counter stats for 'system wide':
S0-D0-C0 1 6,67 Joules power/energy-cores/
S0-D0-C1 1 197,93 Joules power/energy-cores/
S0-D0-C2 1 11,32 Joules power/energy-cores/
S0-D0-C3 1 13,88 Joules power/energy-cores/
S0-D0-C4 1 12,40 Joules power/energy-cores/
S0-D0-C5 1 5,10 Joules power/energy-cores/
S0-D0-C6 1 3,92 Joules power/energy-cores/
S0-D0-C7 1 5,65 Joules power/energy-cores/
S0-D0-C8 1 4,91 Joules power/energy-cores/
S0-D0-C9 1 57,18 Joules power/energy-cores/
S0-D0-C10 1 174,95 Joules power/energy-cores/
S0-D0-C11 1 3,58 Joules power/energy-cores/
S0-D0-C12 1 5,41 Joules power/energy-cores/
S0-D0-C13 1 5,33 Joules power/energy-cores/
S0-D0-C14 1 2,89 Joules power/energy-cores/
S0-D0-C15 1 5,61 Joules power/energy-cores/
17,034519241 seconds time elapsed
```
Tested-by: Oleksandr Natalenko <oleksandr@natalenko.name>
Thanks.
--
Oleksandr Natalenko (post-factum)
prev parent reply other threads:[~2023-03-02 19:46 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-01 18:14 [RFC PATCH v2 0/2] Enable Core RAPL for AMD Wyes Karny
2023-03-01 18:14 ` [RFC PATCH v2 1/2] perf/x86/rapl: Fix energy-cores event Wyes Karny
2023-03-01 19:29 ` Liang, Kan
2023-03-01 18:14 ` [RFC PATCH v2 2/2] perf/x86/rapl: Enable Core RAPL for AMD Wyes Karny
2023-03-02 19:45 ` Oleksandr Natalenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2670154.mvXUDI8C0e@natalenko.name \
--to=oleksandr@natalenko.name \
--cc=acme@kernel.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=ananth.narayan@amd.com \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=eranian@google.com \
--cc=gautham.shenoy@amd.com \
--cc=hpa@zytor.com \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=usama.anjum@collabora.com \
--cc=wyes.karny@amd.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).