From: Vincent Whitchurch <Vincent.Whitchurch@axis.com>
To: "peterz@infradead.org" <peterz@infradead.org>,
"mingo@redhat.com" <mingo@redhat.com>,
"acme@kernel.org" <acme@kernel.org>
Cc: "jolsa@kernel.org" <jolsa@kernel.org>,
"namhyung@kernel.org" <namhyung@kernel.org>,
"linux-perf-users@vger.kernel.org"
<linux-perf-users@vger.kernel.org>,
"mark.rutland@arm.com" <mark.rutland@arm.com>,
kernel <kernel@axis.com>,
"alexander.shishkin@linux.intel.com"
<alexander.shishkin@linux.intel.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] perf annotate: Work with vmlinux outside symfs
Date: Fri, 16 Jun 2023 10:21:52 +0000 [thread overview]
Message-ID: <28e5680b86806cb97f832f5646a0e2e9d8ee68f7.camel@axis.com> (raw)
In-Reply-To: <20221125114210.2353820-1-vincent.whitchurch@axis.com>
On Fri, 2022-11-25 at 12:42 +0100, Vincent Whitchurch wrote:
> It is currently possible to use --symfs along with a vmlinux which lies
> outside of the symfs by passing an absolute path to --vmlinux, thanks to
> the check in dso__load_vmlinux() which handles this explicitly.
>
> However, the annotate code lacks this check and thus perf annotate does
> not work ("Internal error: Invalid -1 error code") for kernel functions
> with this combination. Add the missing handling.
>
> Signed-off-by: Vincent Whitchurch <vincent.whitchurch@axis.com>
This patch was not merged and I did not receive any comments on it
either. Should I resend it? It still applies cleanly to current
mainline. Thanks.
next prev parent reply other threads:[~2023-06-16 10:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-25 11:42 [PATCH] perf annotate: Work with vmlinux outside symfs Vincent Whitchurch
2023-06-16 10:21 ` Vincent Whitchurch [this message]
2023-06-16 13:05 ` Arnaldo Carvalho de Melo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=28e5680b86806cb97f832f5646a0e2e9d8ee68f7.camel@axis.com \
--to=vincent.whitchurch@axis.com \
--cc=acme@kernel.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=jolsa@kernel.org \
--cc=kernel@axis.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).