From mboxrd@z Thu Jan 1 00:00:00 1970 From: Arnaldo Carvalho de Melo Subject: Re: [PATCH] libbpf: Fix up generation of bpf_helper_defs.h Date: Wed, 27 Nov 2019 21:51:15 -0300 Message-ID: <2993CDB0-8D4D-4A0C-9DB2-8FDD1A0538AB@kernel.org> References: <87imn6y4n9.fsf@toke.dk> <20191126183451.GC29071@kernel.org> <87d0dexyij.fsf@toke.dk> <20191126190450.GD29071@kernel.org> <20191126221018.GA22719@kernel.org> <20191126221733.GB22719@kernel.org> <20191126231030.GE3145429@mini-arch.hsd1.ca.comcast.net> <20191126155228.0e6ed54c@cakuba.netronome.com> <20191127013901.GE29071@kernel.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Alexei Starovoitov Cc: Jakub Kicinski , Stanislav Fomichev , Andrii Nakryiko , Arnaldo Carvalho de Melo , =?ISO-8859-1?Q?Toke_H=F8iland-J=F8rgensen?= , Andrii Nakryiko , Adrian Hunter , Alexei Starovoitov , Daniel Borkmann , Jiri Olsa , Martin KaFai Lau , Namhyung Kim , bpf , Networking , linux-perf-users@vger.kernel.org, Linux Kernel Mailing List , Quentin Monnet List-Id: linux-perf-users.vger.kernel.org On November 27, 2019 9:31:41 PM GMT-03:00, Alexei Starovoitov wrote: >On Tue, Nov 26, 2019 at 5:39 PM Arnaldo Carvalho de Melo > wrote: >> >> Em Tue, Nov 26, 2019 at 03:52:28PM -0800, Jakub Kicinski escreveu: >> > On Tue, 26 Nov 2019 15:10:30 -0800, Stanislav Fomichev wrote: >> > > We are using this script with python2=2E7, works just fine :-) >> > > So maybe doing s/python3/python/ is the way to go, whatever >> > > default python is installed, it should work with that=2E >> >> > That increases the risk someone will make a python2-only change >> > and break Python 3=2E >> >> > Python 2 is dead, I'm honestly surprised this needs to be said :) >> >> It shouldn't have to be said, and probably it is old school to try >and >> keep things portable when there is no need to use new stuff for >simple >> tasks like this=2E >> >> Anyway, it seems its just a matter of adding the python3 package to >the >> old container images and then most of them will work with what is in >> that script, what doesn't work is really old and then NO_LIBBPF=3D1 is >the >> way to go=2E >> >> In the end, kinda nothing to see here, go back to adding cool new >stuff, >> lets not hold eBPF from progressing ;-P > >Absolutely=2E I think if some distro is still using 32-bit userland it's >likely >so much behind anything modern that its kernel is equally old too >and appeal of new features (bpf or anything else) is probably low=2E >So if I were you I would keep 32-bit builds of perf supported, but with >minimal effort=2E I try not to assume too much, just try to keep what's being tested to cont= inue to at least build=2E >Re: patch itself=2E >I can take it as-is into bpf tree and it will be in Linus's tree in few >days=2E >Or I can take only tools/lib/bpf/Makefile hunk and you can take >tools/perf/MANIFEST via perf tree? >Whichever way is fine=2E Take it as one, I think it's what should have been in the cset it is fixin= g, that way no breakage would have happened=2E - Arnaldo