From: Anshuman Khandual <anshuman.khandual@arm.com>
To: kernel test robot <lkp@intel.com>,
linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org,
peterz@infradead.org, acme@kernel.org
Cc: kbuild-all@lists.01.org, Suzuki Poulose <suzuki.poulose@arm.com>,
James Clark <james.clark@arm.com>, Ingo Molnar <mingo@redhat.com>,
Mark Rutland <mark.rutland@arm.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@redhat.com>, Namhyung Kim <namhyung@kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
Will Deacon <will@kernel.org>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH V3 05/10] perf: Add PERF_BR_NEW_ARCH_[N] map for BRBE on arm64 platform
Date: Mon, 14 Mar 2022 16:18:35 +0530 [thread overview]
Message-ID: <29ab721c-10bd-68e7-a1e0-8564e60f7584@arm.com> (raw)
In-Reply-To: <202203141608.b9LFCtgv-lkp@intel.com>
On 3/14/22 14:07, kernel test robot wrote:
>>> error: include/uapi/linux/perf_event.h: leak CONFIG_ARM64 to user-space
> make[2]: *** [scripts/Makefile.headersinst:63: usr/include/linux/perf_event.h] Error 1
> make[2]: Target '__headers' not remade because of errors.
> make[1]: *** [Makefile:1277: headers] Error 2
> make[1]: Target 'prepare' not remade because of errors.
> make: *** [Makefile:219: __sub-make] Error 2
> make: Target 'prepare' not remade because of errors.
I should have avoided CONFIG_ARM64 in the the header file which gets
duplicated for tools/include/.. Looking at this once again, platform
build wrappers are not really required for these arch overrides. These
arm64 branch types can co-exist with any other platform overrides when
they get added later on. Just that the branch type nomenclature should
include the platform name some where. Something like ..
PERF_BR_<ARCH>_<BRANCH_TYPE>
#define PERF_BR_ARM64_FIQ PERF_BR_NEW_ARCH_1
#define PERF_BR_ARM64_DEBUG_HALT PERF_BR_NEW_ARCH_2
#define PERF_BR_ARM64_DEBUG_EXIT PERF_BR_NEW_ARCH_3
#define PERF_BR_ARM64_DEBUG_INST PERF_BR_NEW_ARCH_4
#define PERF_BR_ARM64_DEBUG_DATA PERF_BR_NEW_ARCH_5
Will do this change next time around.
- Anshuman
next prev parent reply other threads:[~2022-03-14 10:48 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-14 5:58 [PATCH V3 00/10] perf: Expand perf_branch_entry Anshuman Khandual
2022-03-14 5:58 ` [PATCH V3 01/10] perf: Add irq and exception return branch types Anshuman Khandual
2022-03-14 5:58 ` [PATCH V3 02/10] perf: Add system error and not in transaction " Anshuman Khandual
2022-03-14 5:58 ` [PATCH V3 03/10] perf: Extend branch type classification Anshuman Khandual
2022-03-14 5:58 ` [PATCH V3 04/10] perf: Capture branch privilege information Anshuman Khandual
2022-03-14 5:58 ` [PATCH V3 05/10] perf: Add PERF_BR_NEW_ARCH_[N] map for BRBE on arm64 platform Anshuman Khandual
2022-03-14 8:37 ` kernel test robot
2022-03-14 10:48 ` Anshuman Khandual [this message]
2022-03-14 15:15 ` kernel test robot
2022-03-14 5:58 ` [PATCH V3 06/10] perf/tools: Add irq and exception return branch types Anshuman Khandual
2022-03-14 5:58 ` [PATCH V3 07/10] perf/tools: Add system error and not in transaction " Anshuman Khandual
2022-03-14 5:58 ` [PATCH V3 08/10] perf/tools: Extend branch type classification Anshuman Khandual
2022-03-14 5:58 ` [PATCH V3 09/10] perf/tools: Add branch privilege information request flag Anshuman Khandual
2022-03-14 5:58 ` [PATCH V3 10/10] perf/tools: Add PERF_BR_NEW_ARCH_[N] map for BRBE on arm64 platform Anshuman Khandual
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=29ab721c-10bd-68e7-a1e0-8564e60f7584@arm.com \
--to=anshuman.khandual@arm.com \
--cc=acme@kernel.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=james.clark@arm.com \
--cc=jolsa@redhat.com \
--cc=kbuild-all@lists.01.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=lkp@intel.com \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=suzuki.poulose@arm.com \
--cc=tglx@linutronix.de \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).