From: Dave Hansen <dave.hansen@intel.com>
To: Aldo Conte <aldocontelk@gmail.com>,
peterz@infradead.org, mingo@redhat.com, acme@kernel.org,
namhyung@kernel.org, tglx@kernel.org, bp@alien8.de,
dave.hansen@linux.intel.com
Cc: mark.rutland@arm.com, alexander.shishkin@linux.intel.com,
jolsa@kernel.org, irogers@google.com, adrian.hunter@intel.com,
james.clark@linaro.org, hpa@zytor.com, x86@kernel.org,
linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org,
skhan@linuxfoundation.org
Subject: Re: [PATCH] perf/x86/intel/p4: Fix unused variable warning in p4_pmu_init()
Date: Thu, 19 Mar 2026 15:24:29 -0700 [thread overview]
Message-ID: <2b097880-b2fc-498f-9dab-db875a4dec83@intel.com> (raw)
In-Reply-To: <a8a8ad35-7e92-41ec-b6a5-b471a91811b2@gmail.com>
On 3/19/26 15:20, Aldo Conte wrote:
> I admit I'm a novice in this field, so what do you suggest is the best
> fix at this point?
> Should I use the “warning suppressor" with something like
> (void) val1 = (u32)_l; \
> (void) val2 = _l >> 32; \
> or implement the solution you suggested?
Ideally, someone should go consolidate the two copies.
But, for now, for the p4.c issue, I'm still happy with transitioning
over to rdmsrq().
next prev parent reply other threads:[~2026-03-19 22:24 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-19 15:22 [PATCH] perf/x86/intel/p4: Fix unused variable warning in p4_pmu_init() Aldo Conte
2026-03-19 15:30 ` Dave Hansen
2026-03-19 22:20 ` Aldo Conte
2026-03-19 22:24 ` Dave Hansen [this message]
2026-03-20 11:23 ` [PATCH v2] " Aldo Conte
2026-03-24 14:10 ` Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2b097880-b2fc-498f-9dab-db875a4dec83@intel.com \
--to=dave.hansen@intel.com \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=aldocontelk@gmail.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=irogers@google.com \
--cc=james.clark@linaro.org \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=skhan@linuxfoundation.org \
--cc=tglx@kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox