From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 188F3C77B72 for ; Thu, 20 Apr 2023 12:23:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234196AbjDTMXj (ORCPT ); Thu, 20 Apr 2023 08:23:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45814 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233945AbjDTMXi (ORCPT ); Thu, 20 Apr 2023 08:23:38 -0400 Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 814A38F; Thu, 20 Apr 2023 05:23:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1681993417; x=1713529417; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=Yv4blA62X3WJ+SUshSA+UbW4er8IVJsm5Rvo7sAhWrI=; b=QwZluq1PuHKpO7oy5GEgKJmW8xVowWqnJXkFU9zqMG2Lb9ql09Pp6UJ2 1nKYjJVfx4X8bimqnsI7AHiMRvGdu8a/AHmvVya4rpK9CXT5npPOpAvFY Cmc1U50JyWPHMfbdpykEOhnchKQUZkX0HdJfxk0WUr/fKHQNrv4bLlOVO SxXlp9PyCYK8FS9sITxMHY3D3/tu+dPFO3y3m8GRa0U1cXetGDLssOVCl cWDqi3UWYvf5r59Zk12OJxcK6mIR0bxjCvoewvmOPrWCEMVEHnT9K+w3c oU0Bp5tj4l6BF8CNbOjgtZI2ZI931OS66QLC9PA9Cx9rQ2zjyZj/De4Yj g==; X-IronPort-AV: E=McAfee;i="6600,9927,10685"; a="334550439" X-IronPort-AV: E=Sophos;i="5.99,212,1677571200"; d="scan'208";a="334550439" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Apr 2023 05:23:37 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10685"; a="803323357" X-IronPort-AV: E=Sophos;i="5.99,212,1677571200"; d="scan'208";a="803323357" Received: from linux.intel.com ([10.54.29.200]) by fmsmga002.fm.intel.com with ESMTP; 20 Apr 2023 05:23:36 -0700 Received: from [10.255.228.114] (kliang2-mobl1.ccr.corp.intel.com [10.255.228.114]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by linux.intel.com (Postfix) with ESMTPS id 27332580BBE; Thu, 20 Apr 2023 05:22:57 -0700 (PDT) Message-ID: <2b4f404c-24bf-a57a-1335-ae2fed18ddbb@linux.intel.com> Date: Thu, 20 Apr 2023 08:22:56 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [PATCH v2] perf stat: Introduce skippable evsels To: Arnaldo Carvalho de Melo , Ian Rogers Cc: Stephane Eranian , Andi Kleen , "Yasin, Ahmad" , "Taylor, Perry" , "Alt, Samantha" , "Biggers, Caleb" , "Wang, Weilin" , Edward , Peter Zijlstra , Ingo Molnar , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , Adrian Hunter , Florian Fischer , linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org References: <99150cb1-fe50-97cf-ad80-cceb9194eb9a@linux.intel.com> <84b19053-2e9f-5251-6816-26d2475894c0@linux.intel.com> <201a2ad6-3fb4-4b2a-d8a4-34d924e680c3@linux.intel.com> Content-Language: en-US From: "Liang, Kan" In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-perf-users@vger.kernel.org On 2023-04-20 7:33 a.m., Arnaldo Carvalho de Melo wrote: > Em Wed, Apr 19, 2023 at 09:51:20AM -0700, Ian Rogers escreveu: >> On Wed, Apr 19, 2023 at 7:16 AM Liang, Kan wrote: >>> For ADL/RPL platforms >>> - Segmentation fault which I just found this morning. >>> # ./perf stat true >>> Segmentation fault (core dumped) > >> This may also stem from the reference count checking work that Arnaldo >> is currently merging. It is hard to test hybrid because it uses >> non-generic code paths. > > Hey, could you please try this under gdb and provide a backtrace? Here is the backtrace. #0 get_group_fd (thread=0, cpu_map_idx=, evsel=0x555556015af0) at util/evsel.c:1722 #1 evsel__open_cpu (evsel=, cpus=, threads=, start_cpu_map_idx=, end_cpu_map_idx=) at util/evsel.c:2105 #2 0x000055555561dd9e in __run_perf_stat (run_idx=, argv=0x7fffffffe1d0, argc=1) at builtin-stat.c:734 #3 run_perf_stat (run_idx=, argv=0x7fffffffe1d0, argc=1) at builtin-stat.c:949 #4 cmd_stat (argc=1, argv=0x7fffffffe1d0) at builtin-stat.c:2537 #5 0x00005555556b56a0 in run_builtin (p=p@entry=0x555555f84450 , argc=argc@entry=2, argv=argv@entry=0x7fffffffe1d0) at perf.c:323 #6 0x00005555555fe2d9 in handle_internal_command (argv=0x7fffffffe1d0, argc=2) at perf.c:377 #7 run_argv (argv=, argcp=) at perf.c:421 #8 main (argc=2, argv=0x7fffffffe1d0) at perf.c:537 Thanks, Kan > It may > indeed be related to this refcount checking work, there was a bug fixed > by the ARM guys for cs-etm and I combed thru and fixed some other use > before check for NULL cases, maybe one more slipped up. > > Here I couldn't reproduce, but I don't have a Intel hybrid system, will > check with an ARM, but unsure if it will exercise the same code paths... > > - Arnaldo