* [PATCH] perf parse-events: Remove unneeded semicolon [not found] <20230614080937.54937-1-luojianhong@cdjrlc.com> @ 2023-06-14 8:13 ` baomingtong001 2023-06-14 13:55 ` Arnaldo Carvalho de Melo 2023-06-20 22:50 ` Namhyung Kim 0 siblings, 2 replies; 4+ messages in thread From: baomingtong001 @ 2023-06-14 8:13 UTC (permalink / raw) To: peterz, mingo, acme, mark.rutland, alexander.shishkin, jolsa, namhyung, irogers, adrian.hunter, kan.liang, zhengjun.xing Cc: linux-perf-users, linux-kernel ./tools/perf/util/parse-events.c:1466:2-3: Unneeded semicolon Signed-off-by: Mingtong Bao <baomingtong001@208suo.com> --- tools/perf/util/parse-events.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/perf/util/parse-events.c b/tools/perf/util/parse-events.c index 629f7bd9fd59..42f84f61fabc 100644 --- a/tools/perf/util/parse-events.c +++ b/tools/perf/util/parse-events.c @@ -1463,7 +1463,7 @@ static int __parse_events_add_numeric(struct parse_events_state *parse_state, if (extended_type && (type == PERF_TYPE_HARDWARE || type == PERF_TYPE_HW_CACHE)) { assert(perf_pmus__supports_extended_type()); attr.config |= (u64)extended_type << PERF_PMU_TYPE_SHIFT; - }; + } if (head_config) { if (config_attr(&attr, head_config, parse_state->error, ^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] perf parse-events: Remove unneeded semicolon 2023-06-14 8:13 ` [PATCH] perf parse-events: Remove unneeded semicolon baomingtong001 @ 2023-06-14 13:55 ` Arnaldo Carvalho de Melo 2023-06-20 22:50 ` Namhyung Kim 1 sibling, 0 replies; 4+ messages in thread From: Arnaldo Carvalho de Melo @ 2023-06-14 13:55 UTC (permalink / raw) To: baomingtong001 Cc: peterz, mingo, mark.rutland, alexander.shishkin, jolsa, namhyung, irogers, adrian.hunter, kan.liang, zhengjun.xing, linux-perf-users, linux-kernel Em Wed, Jun 14, 2023 at 04:13:53PM +0800, baomingtong001@208suo.com escreveu: > ./tools/perf/util/parse-events.c:1466:2-3: Unneeded semicolon Was this detected by some tool? Which one? - Arnaldo > Signed-off-by: Mingtong Bao <baomingtong001@208suo.com> > --- > tools/perf/util/parse-events.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tools/perf/util/parse-events.c b/tools/perf/util/parse-events.c > index 629f7bd9fd59..42f84f61fabc 100644 > --- a/tools/perf/util/parse-events.c > +++ b/tools/perf/util/parse-events.c > @@ -1463,7 +1463,7 @@ static int __parse_events_add_numeric(struct > parse_events_state *parse_state, > if (extended_type && (type == PERF_TYPE_HARDWARE || type == > PERF_TYPE_HW_CACHE)) { > assert(perf_pmus__supports_extended_type()); > attr.config |= (u64)extended_type << PERF_PMU_TYPE_SHIFT; > - }; > + } > > if (head_config) { > if (config_attr(&attr, head_config, parse_state->error, -- - Arnaldo ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] perf parse-events: Remove unneeded semicolon 2023-06-14 8:13 ` [PATCH] perf parse-events: Remove unneeded semicolon baomingtong001 2023-06-14 13:55 ` Arnaldo Carvalho de Melo @ 2023-06-20 22:50 ` Namhyung Kim 2023-06-21 17:24 ` Namhyung Kim 1 sibling, 1 reply; 4+ messages in thread From: Namhyung Kim @ 2023-06-20 22:50 UTC (permalink / raw) To: baomingtong001 Cc: peterz, mingo, acme, mark.rutland, alexander.shishkin, jolsa, irogers, adrian.hunter, kan.liang, zhengjun.xing, linux-perf-users, linux-kernel Hello, On Wed, Jun 14, 2023 at 1:13 AM <baomingtong001@208suo.com> wrote: > > ./tools/perf/util/parse-events.c:1466:2-3: Unneeded semicolon > > Signed-off-by: Mingtong Bao <baomingtong001@208suo.com> > --- > tools/perf/util/parse-events.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tools/perf/util/parse-events.c > b/tools/perf/util/parse-events.c > index 629f7bd9fd59..42f84f61fabc 100644 > --- a/tools/perf/util/parse-events.c > +++ b/tools/perf/util/parse-events.c > @@ -1463,7 +1463,7 @@ static int __parse_events_add_numeric(struct > parse_events_state *parse_state, > if (extended_type && (type == PERF_TYPE_HARDWARE || type == > PERF_TYPE_HW_CACHE)) { The format is broken, please fix your mail client not fix wrap long lines. This time I fixed it manually, but you need to update your config. Thanks, Namhyung > assert(perf_pmus__supports_extended_type()); > attr.config |= (u64)extended_type << PERF_PMU_TYPE_SHIFT; > - }; > + } > > if (head_config) { > if (config_attr(&attr, head_config, parse_state->error, ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] perf parse-events: Remove unneeded semicolon 2023-06-20 22:50 ` Namhyung Kim @ 2023-06-21 17:24 ` Namhyung Kim 0 siblings, 0 replies; 4+ messages in thread From: Namhyung Kim @ 2023-06-21 17:24 UTC (permalink / raw) To: baomingtong001 Cc: peterz, mingo, acme, mark.rutland, alexander.shishkin, jolsa, irogers, adrian.hunter, kan.liang, zhengjun.xing, linux-perf-users, linux-kernel On Tue, Jun 20, 2023 at 3:50 PM Namhyung Kim <namhyung@kernel.org> wrote: > > Hello, > > On Wed, Jun 14, 2023 at 1:13 AM <baomingtong001@208suo.com> wrote: > > > > ./tools/perf/util/parse-events.c:1466:2-3: Unneeded semicolon > > > > Signed-off-by: Mingtong Bao <baomingtong001@208suo.com> > > --- > > tools/perf/util/parse-events.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/tools/perf/util/parse-events.c > > b/tools/perf/util/parse-events.c > > index 629f7bd9fd59..42f84f61fabc 100644 > > --- a/tools/perf/util/parse-events.c > > +++ b/tools/perf/util/parse-events.c > > @@ -1463,7 +1463,7 @@ static int __parse_events_add_numeric(struct > > parse_events_state *parse_state, > > if (extended_type && (type == PERF_TYPE_HARDWARE || type == > > PERF_TYPE_HW_CACHE)) { > > The format is broken, please fix your mail client not fix wrap long lines. > This time I fixed it manually, but you need to update your config. Also there were other whitespace breakages, but applied to perf-tools-next anyway, thanks! ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-06-21 17:24 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20230614080937.54937-1-luojianhong@cdjrlc.com>
2023-06-14 8:13 ` [PATCH] perf parse-events: Remove unneeded semicolon baomingtong001
2023-06-14 13:55 ` Arnaldo Carvalho de Melo
2023-06-20 22:50 ` Namhyung Kim
2023-06-21 17:24 ` Namhyung Kim
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).