From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BADD1C77B61 for ; Thu, 27 Apr 2023 20:02:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244781AbjD0UCT (ORCPT ); Thu, 27 Apr 2023 16:02:19 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43530 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229750AbjD0UCS (ORCPT ); Thu, 27 Apr 2023 16:02:18 -0400 Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1960F2D74; Thu, 27 Apr 2023 13:02:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1682625737; x=1714161737; h=message-id:date:mime-version:subject:to:references:from: in-reply-to:content-transfer-encoding; bh=cj+IzPjwDDjU0dEpBGzoC7xu4ot/pyj5P09xXcocUfs=; b=YjhsGScNmGxGVc7TaZL7EPR1D9iViimzD1lGckgQ4tHZ6nN4ojecEJH2 tJmC3OlV441hyBkckG29NwqbMdMYgLmpn9VUiqBz4Iw3+0mfnyb/f6j7+ 48sJESFK1IY0GlPn/TwbdmpplrUrMvR4c5mihPYhw5VeFaBM9fPDd0K2n 0y8RYX8cE40Nw9a5FKhh8WALQb8TId4QzOUSBvAcbuqvCgsH5VL2FqTIn 1734QV3Pbrwnf12AqJAyMKvRy9Z9abiG7098J6WljbJvEmQ/31IlThkj8 wmFY8H29Y9wBw5fyF7rm5qyO1cITBP/uvUNSf7SSYnU5bwu8E+iUBqfCb Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10693"; a="331842814" X-IronPort-AV: E=Sophos;i="5.99,232,1677571200"; d="scan'208";a="331842814" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Apr 2023 13:00:53 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10693"; a="1024254941" X-IronPort-AV: E=Sophos;i="5.99,232,1677571200"; d="scan'208";a="1024254941" Received: from linux.intel.com ([10.54.29.200]) by fmsmga005.fm.intel.com with ESMTP; 27 Apr 2023 13:00:53 -0700 Received: from [10.209.41.222] (kliang2-mobl1.ccr.corp.intel.com [10.209.41.222]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by linux.intel.com (Postfix) with ESMTPS id 91DB3580377; Thu, 27 Apr 2023 13:00:49 -0700 (PDT) Message-ID: <329abaf5-8c21-c7a9-30e4-fec2a3c38e3c@linux.intel.com> Date: Thu, 27 Apr 2023 16:00:48 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [PATCH v1 13/40] perf parse-events: Set attr.type to PMU type early Content-Language: en-US To: Ian Rogers , Arnaldo Carvalho de Melo , Ahmad Yasin , Peter Zijlstra , Ingo Molnar , Stephane Eranian , Andi Kleen , Perry Taylor , Samantha Alt , Caleb Biggers , Weilin Wang , Edward Baker , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , Adrian Hunter , Florian Fischer , Rob Herring , Zhengjun Xing , John Garry , Kajol Jain , Sumanth Korikkar , Thomas Richter , Tiezhu Yang , Ravi Bangoria , Leo Yan , Yang Jihong , James Clark , Suzuki Poulouse , Kang Minchul , Athira Rajeev , linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org References: <20230426070050.1315519-1-irogers@google.com> <20230426070050.1315519-14-irogers@google.com> From: "Liang, Kan" In-Reply-To: <20230426070050.1315519-14-irogers@google.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-perf-users@vger.kernel.org On 2023-04-26 3:00 a.m., Ian Rogers wrote: > Set attr.type to PMU type early so that later terms can override the > value. Setting the value in perf_pmu__config means that earlier steps, > like config_term_pmu, can override the value. > Looks good to me. Reviewed-by: Kan Liang Thanks, Kan > Signed-off-by: Ian Rogers --- > tools/perf/util/parse-events.c | 2 +- > tools/perf/util/pmu.c | 1 - > 2 files changed, 1 insertion(+), 2 deletions(-) > > diff --git a/tools/perf/util/parse-events.c b/tools/perf/util/parse-events.c > index d71019dcd614..4ba01577618e 100644 > --- a/tools/perf/util/parse-events.c > +++ b/tools/perf/util/parse-events.c > @@ -1492,9 +1492,9 @@ int parse_events_add_pmu(struct parse_events_state *parse_state, > } else { > memset(&attr, 0, sizeof(attr)); > } > + attr.type = pmu->type; > > if (!head_config) { > - attr.type = pmu->type; > evsel = __add_event(list, &parse_state->idx, &attr, > /*init_attr=*/true, /*name=*/NULL, > /*metric_id=*/NULL, pmu, > diff --git a/tools/perf/util/pmu.c b/tools/perf/util/pmu.c > index ad209c88a124..cb33d869f1ed 100644 > --- a/tools/perf/util/pmu.c > +++ b/tools/perf/util/pmu.c > @@ -1398,7 +1398,6 @@ int perf_pmu__config(struct perf_pmu *pmu, struct perf_event_attr *attr, > { > bool zero = !!pmu->default_config; > > - attr->type = pmu->type; > return perf_pmu__config_terms(pmu->name, &pmu->format, attr, > head_terms, zero, err); > }