From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B038AEB64DD for ; Tue, 25 Jul 2023 04:41:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230389AbjGYElj (ORCPT ); Tue, 25 Jul 2023 00:41:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:32970 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229470AbjGYEli (ORCPT ); Tue, 25 Jul 2023 00:41:38 -0400 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 8795910D1; Mon, 24 Jul 2023 21:41:37 -0700 (PDT) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 768CE11FB; Mon, 24 Jul 2023 21:42:20 -0700 (PDT) Received: from [10.163.51.115] (unknown [10.163.51.115]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id C1AB93F67D; Mon, 24 Jul 2023 21:41:29 -0700 (PDT) Message-ID: <354fcd14-e86a-fe51-2613-6194b85efd25@arm.com> Date: Tue, 25 Jul 2023 10:11:26 +0530 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [PATCH v2 3/4] arm_pmu: Remove unused PERF_PMU_CAP_HETEROGENEOUS_CPUS capability Content-Language: en-US To: James Clark , linux-perf-users@vger.kernel.org, irogers@google.com, will@kernel.org Cc: Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , Adrian Hunter , Thomas Gleixner , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Kan Liang , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org References: <20230724134500.970496-1-james.clark@arm.com> <20230724134500.970496-4-james.clark@arm.com> From: Anshuman Khandual In-Reply-To: <20230724134500.970496-4-james.clark@arm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-perf-users@vger.kernel.org On 7/24/23 19:14, James Clark wrote: > Since commit bd2756811766 ("perf: Rewrite core context handling") the > relationship between perf_event_context and PMUs has changed so that > the error scenario that PERF_PMU_CAP_HETEROGENEOUS_CPUS originally > silenced no longer exists. > > Remove the capability and associated comment to avoid confusion that it > actually influences any perf core behavior. This change should be a > no-op. > > Acked-by: Ian Rogers > Signed-off-by: James Clark Reviewed-by: Anshuman Khandual > --- > drivers/perf/arm_pmu.c | 7 ++----- > 1 file changed, 2 insertions(+), 5 deletions(-) > > diff --git a/drivers/perf/arm_pmu.c b/drivers/perf/arm_pmu.c > index 2e79201daa4a..d712a19e47ac 100644 > --- a/drivers/perf/arm_pmu.c > +++ b/drivers/perf/arm_pmu.c > @@ -877,15 +877,12 @@ struct arm_pmu *armpmu_alloc(void) > .attr_groups = pmu->attr_groups, > /* > * This is a CPU PMU potentially in a heterogeneous > - * configuration (e.g. big.LITTLE). This is not an uncore PMU, > - * and we have taken ctx sharing into account (e.g. with our > - * pmu::filter callback and pmu::event_init group validation). > - * > + * configuration (e.g. big.LITTLE) so > * PERF_PMU_CAP_EXTENDED_HW_TYPE is required to open > * PERF_TYPE_HARDWARE and PERF_TYPE_HW_CACHE events on a > * specific PMU. > */ > - .capabilities = PERF_PMU_CAP_HETEROGENEOUS_CPUS | PERF_PMU_CAP_EXTENDED_REGS | > + .capabilities = PERF_PMU_CAP_EXTENDED_REGS | > PERF_PMU_CAP_EXTENDED_HW_TYPE, > }; >