From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id AE763EB64DD for ; Tue, 27 Jun 2023 09:54:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231452AbjF0Jyj (ORCPT ); Tue, 27 Jun 2023 05:54:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52100 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230273AbjF0JyM (ORCPT ); Tue, 27 Jun 2023 05:54:12 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id ACE652D65 for ; Tue, 27 Jun 2023 02:53:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1687859593; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=DERs8uzDMpyvp9qgsa7AlFpdBE9PZMETpYtSHAfUjAo=; b=EVNd5lkvGS11i2uuTIC9MmOyduPyr+E3UlQWX4Wfyot4fUS1ye44xCf4NSo+HmpYy0Psrl rX2n6wQd5AYxEQdgvyorhsB2dMwYGx0B1+OWuGXanm4885SEVTEhaCSbR6sDGazMaTYIOB dJF5p09DCx/kbNHN276gh2JPtCbJ/V0= Received: from mail-qt1-f198.google.com (mail-qt1-f198.google.com [209.85.160.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-564-xYEEAEkVMVqY1JxCv5UjoA-1; Tue, 27 Jun 2023 05:53:12 -0400 X-MC-Unique: xYEEAEkVMVqY1JxCv5UjoA-1 Received: by mail-qt1-f198.google.com with SMTP id d75a77b69052e-3f9e7a1caf2so14099261cf.0 for ; Tue, 27 Jun 2023 02:53:12 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687859591; x=1690451591; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=DERs8uzDMpyvp9qgsa7AlFpdBE9PZMETpYtSHAfUjAo=; b=UIV9Qn2TFslJo1iv++TEE5UwX30/lLMHPmM613O4KGYh78KzNZjdY5+gbAT5GtfhxL dAyqFvFhzoY0T/pjoyMQ0VOm9p5bRNlUk21sfI6ia0K0I4zP7ihAr3JEaA4Ku5TADPHk KJ2WM+x2WxIc5+yTU++EBckl1frSRpq3v3ImCrQSOTCJBu9LHDO6Qx4gc3YBHCBGTUny ajeP1mXod/NT1zkvvkMaN4SYUWv52qt2TLrrXoKCPu05FBtryDBkZZf+HRJy91UrEVar CLVKC4ysNB1rcoQ660RVXo79Qxg6RKXzxK6KKeMMumtDGFDBUPU3Fk61721e+xUvbtrs Lp9Q== X-Gm-Message-State: AC+VfDxTFpam902iWjT/t7BBWVwBAGvdFwis0aIaQr/9MyTXmL1w0Hrb pLHX0NiRAYF5v+QS0s6QO15T1C92DEMKDg2w47b2C4ALoWU9ioMAVUQAEh8FK+JwFSdafOy5S1v DfKoXEVJWcjbwO6f0QPnOc+kfquSLpA== X-Received: by 2002:a05:622a:1191:b0:3f6:b493:8ee4 with SMTP id m17-20020a05622a119100b003f6b4938ee4mr39729427qtk.0.1687859591381; Tue, 27 Jun 2023 02:53:11 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ5aXj4A9G6QhV47CSXT3MixoO5CAWu5oDZ2HUASdv+XCpyT8RMvKYE/1Knu3xwkhDYnqez+CA== X-Received: by 2002:a05:622a:1191:b0:3f6:b493:8ee4 with SMTP id m17-20020a05622a119100b003f6b4938ee4mr39729413qtk.0.1687859591104; Tue, 27 Jun 2023 02:53:11 -0700 (PDT) Received: from gerbillo.redhat.com (146-241-239-6.dyn.eolo.it. [146.241.239.6]) by smtp.gmail.com with ESMTPSA id cq14-20020a05622a424e00b003f9bccc3182sm208798qtb.32.2023.06.27.02.53.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 27 Jun 2023 02:53:10 -0700 (PDT) Message-ID: <35d67fc65d5ff70c102040ce095a7c4a8b5da8bb.camel@redhat.com> Subject: Re: [PATCH net-next] tools: Fix MSG_SPLICE_PAGES build error in trace tools From: Paolo Abeni To: Namhyung Kim , Jakub Kicinski Cc: Matthieu Baerts , David Howells , netdev@vger.kernel.org, Arnaldo Carvalho de Melo , David Miller , Eric Dumazet , Jens Axboe , Matthew Wilcox , Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Mark Rutland , Alexander Shishkin , Jiri Olsa , Ian Rogers , Adrian Hunter , linux-perf-users@vger.kernel.org, bpf@vger.kernel.org, linux-next@vger.kernel.org, linux-kernel@vger.kernel.org Date: Tue, 27 Jun 2023 11:53:05 +0200 In-Reply-To: References: <5791ec06-7174-9ae5-4fe4-6969ed110165@tessares.net> <3065880.1687785614@warthog.procyon.org.uk> <3067876.1687787456@warthog.procyon.org.uk> <2cb3b411-9010-a44b-ebee-1914e7fd7b9c@tessares.net> <20230626145353.468fd133@kernel.org> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.46.4 (3.46.4-1.fc37) MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-perf-users@vger.kernel.org On Mon, 2023-06-26 at 14:59 -0700, Namhyung Kim wrote: > On Mon, Jun 26, 2023 at 2:53=E2=80=AFPM Jakub Kicinski = wrote: > >=20 > > On Mon, 26 Jun 2023 14:31:39 -0700 Namhyung Kim wrote: > > > Right, we want to keep the headers files in the tools in sync with > > > the kernel ones. And they are used to generate some tables. > > > Full explanation from Arnaldo below. > > >=20 > > > So I'm ok for the msg_flags.c changes, but please refrain from > > > changing the header directly. We will update it later. > > >=20 > > > With that, > > > Acked-by: Namhyung Kim > >=20 > > Ah, missed this email, sounds like this is preferred to Matthieu's > > fix, we'll take this one. >=20 > Hmm.. I believe they are the same when it comes to the > changes in the .c file. >=20 > >=20 > > > Also I wonder if the tool needs to keep the original flag > > > (SENDPAGE_NOTLAST) for the older kernels. > >=20 > > That's a bit unclear, because it's just a kernel-internal flag. > > Future kernels may well use that bit for something else. >=20 > Ah, ok then. I thought it's a user-visible flag. >=20 > >=20 > > Better long term solution would be to use an enum so that the values > > are included in debuginfo and perf can read them at runtime :( >=20 > Right, we also consider BTF to read the values and hopefully > get rid of the business of copying kernel headers. I read all the above as the preferred solution is the one provided by Mat's patch (not touching socket.h, same changes as here in msg_flags.c. As such, I'll restore Mat's patch in PW and will obsolete this one. Please raise a flag if I'm wrong ;) Cheers, Paolo