From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 63A212CCA0; Mon, 15 Apr 2024 08:25:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.140.110.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713169535; cv=none; b=RbJQs478ayxBkJIrzqVkF7sbgBJsXw6bYflFJ9UFYEbU12gAXwj1gCg6UekqVAwQ0q0IVgBUbYxe/dF+nzCYwjep6/ME7SH1zAjCJdx7zJ5NA0HBxtmm5R8U8gzrh6gr+sxjKwPeRNt5P14fvQgFr09uwrm+IL/xeuYVcuJo60A= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713169535; c=relaxed/simple; bh=qDhIoA5X9Uayi7gC6/5PG+iuxYc1sZ9dQRoAKjmjsCk=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=R9E+Enu+9ZWEIepfvBHSUN4zZU4WwfuOgJTfPc/qZwRR4ePC8VRRvac6QLNOukZbd41O4P59tILjH07a+vjUDROdbbr6dvT83ApS+OG7jF+xB4aSznswhRbsrY+Zonnwl/Oc42+UM8GY3UlosiSSC1urHq4T0BuRiGbp4t5HuGY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com; spf=pass smtp.mailfrom=arm.com; arc=none smtp.client-ip=217.140.110.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 118B52F; Mon, 15 Apr 2024 01:26:02 -0700 (PDT) Received: from [10.162.41.8] (a077893.blr.arm.com [10.162.41.8]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id C2B6A3F64C; Mon, 15 Apr 2024 01:25:28 -0700 (PDT) Message-ID: <369b29bf-66d8-4876-ae0c-a35f3c46973e@arm.com> Date: Mon, 15 Apr 2024 13:55:25 +0530 Precedence: bulk X-Mailing-List: linux-perf-users@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] perf test: Increase buffer size for Coresight basic tests Content-Language: en-US To: James Clark , linux-perf-users@vger.kernel.org Cc: Mike Leach , Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Namhyung Kim , Mark Rutland , Alexander Shishkin , Jiri Olsa , Ian Rogers , Adrian Hunter , coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <20240326113749.257250-1-james.clark@arm.com> <5a4023aa-af9b-48d2-84f3-a0b9b30dc54e@arm.com> <7f5c32dd-edc6-4b53-9cdd-780756f5536c@arm.com> From: Anshuman Khandual In-Reply-To: <7f5c32dd-edc6-4b53-9cdd-780756f5536c@arm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 4/12/24 13:52, James Clark wrote: > > > On 12/04/2024 08:04, Anshuman Khandual wrote: >> >> >> On 3/26/24 17:07, James Clark wrote: >>> These tests record in a mode that includes kernel trace but look for >>> samples of a userspace process. This makes them sensitive to any kernel >>> compilation options that increase the amount of time spent in the >>> kernel. If the trace buffer is completely filled before userspace is >>> reached then the test will fail. Double the buffer size to fix this. >> >> This is a valid concern to address, but just wondering how did we arrive >> at the conclusion that doubling the buffer size i.e making that 8M will >> solve the problem positively for vast number of kerne build scenarios ? >> > > Nobody else has reported anything yet, if it happens again we can always > increase it again if that is what the issue is. I had most of the kernel > debugging stuff turned on like memory debugging etc, which is probably > why I ran into it and 8MB fixed it for me. So I'm not sure if there is > much more that could be added. Makes sense, Reviewed-by: Anshuman Khandual > >>> >>> The other tests in the same file aren't sensitive to this for various >>> reasons, for example the iterate devices test filters by userspace >>> trace only. But in order to keep coverage of all the modes, increase the >>> buffer size rather than filtering by userspace for the basic tests. >>> >>> Fixes: d1efa4a0a696 ("perf cs-etm: Add separate decode paths for timeless and per-thread modes") >>> Signed-off-by: James Clark >>> --- >>> tools/perf/tests/shell/test_arm_coresight.sh | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/tools/perf/tests/shell/test_arm_coresight.sh b/tools/perf/tests/shell/test_arm_coresight.sh >>> index 65dd85207125..3302ea0b9672 100755 >>> --- a/tools/perf/tests/shell/test_arm_coresight.sh >>> +++ b/tools/perf/tests/shell/test_arm_coresight.sh >>> @@ -188,7 +188,7 @@ arm_cs_etm_snapshot_test() { >>> >>> arm_cs_etm_basic_test() { >>> echo "Recording trace with '$*'" >>> - perf record -o ${perfdata} "$@" -- ls > /dev/null 2>&1 >>> + perf record -o ${perfdata} "$@" -m,8M -- ls > /dev/null 2>&1 >>> >>> perf_script_branch_samples ls && >>> perf_report_branch_samples ls && > _______________________________________________ > CoreSight mailing list -- coresight@lists.linaro.org > To unsubscribe send an email to coresight-leave@lists.linaro.org