From: Leo Yan <leo.yan@arm.com>
To: James Clark <james.clark@linaro.org>
Cc: Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Namhyung Kim <namhyung@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@kernel.org>, Ian Rogers <irogers@google.com>,
Adrian Hunter <adrian.hunter@intel.com>,
"Liang, Kan" <kan.liang@linux.intel.com>,
Suzuki K Poulose <suzuki.poulose@arm.com>,
Mike Leach <mike.leach@linaro.org>,
John Garry <john.g.garry@oracle.com>,
Will Deacon <will@kernel.org>, Leo Yan <leo.yan@linux.dev>,
Ben Gainey <ben.gainey@arm.com>,
Ruidong Tian <tianruidong@linux.alibaba.com>,
Benjamin Gray <bgray@linux.ibm.com>,
Mathieu Poirier <mathieu.poirier@linaro.org>,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-perf-users@vger.kernel.org,
gankulkarni@os.amperecomputing.com, coresight@lists.linaro.org,
scclevenger@os.amperecomputing.com
Subject: Re: [PATCH v2 2/7] perf cs-etm: Use new OpenCSD consistency checks
Date: Fri, 13 Sep 2024 14:03:23 +0100 [thread overview]
Message-ID: <37f8d0c3-f1fc-495f-b4c4-549ffa0435d1@arm.com> (raw)
In-Reply-To: <332e0654-df8c-44b1-8e55-398aeba37b08@linaro.org>
On 9/13/24 13:09, James Clark wrote:
[...]
>> Just one question: should the flag ETM4_OPFLG_PKTDEC_AA64_OPCODE_CHK be set
>> according to ETM version? E.g. it should be only set for ETMv4 or this is
>> fine for ETE as well.
>
> I asked Mike the same question about ETMv3 and he said none of the flags
> overlap and it was ok to always pass them. So I assume the same applies
> to ETE as well.
Thanks for confirmation. This is my review tag:
Reviewed-by: Leo Yan <leo.yan@arm.com>
next prev parent reply other threads:[~2024-09-13 13:03 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-12 15:11 [PATCH v2 0/7] perf: cs-etm: Coresight decode and disassembly improvements James Clark
2024-09-12 15:11 ` [PATCH v2 1/7] perf cs-etm: Don't flush when packet_queue fills up James Clark
2024-09-13 11:17 ` Leo Yan
2024-09-12 15:11 ` [PATCH v2 2/7] perf cs-etm: Use new OpenCSD consistency checks James Clark
2024-09-13 11:54 ` Leo Yan
2024-09-13 12:09 ` James Clark
2024-09-13 13:03 ` Leo Yan [this message]
2024-09-12 15:11 ` [PATCH v2 3/7] perf scripting python: Add function to get a config value James Clark
2024-09-13 13:40 ` Leo Yan
2024-09-12 15:11 ` [PATCH v2 4/7] perf scripts python cs-etm: Update to use argparse James Clark
2024-09-13 12:44 ` Leo Yan
2024-09-12 15:11 ` [PATCH v2 5/7] perf scripts python cs-etm: Improve arguments James Clark
2024-09-13 13:01 ` Leo Yan
2024-09-12 15:11 ` [PATCH v2 6/7] perf scripts python cs-etm: Add start and stop arguments James Clark
2024-09-13 13:20 ` Leo Yan
2024-09-16 10:41 ` James Clark
2024-09-12 15:11 ` [PATCH v2 7/7] perf test: cs-etm: Test Coresight disassembly script James Clark
2024-09-13 13:35 ` Leo Yan
2024-09-16 13:25 ` James Clark
2024-09-12 19:23 ` [PATCH v2 0/7] perf: cs-etm: Coresight decode and disassembly improvements Arnaldo Carvalho de Melo
2024-09-17 8:15 ` James Clark
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=37f8d0c3-f1fc-495f-b4c4-549ffa0435d1@arm.com \
--to=leo.yan@arm.com \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=ben.gainey@arm.com \
--cc=bgray@linux.ibm.com \
--cc=coresight@lists.linaro.org \
--cc=gankulkarni@os.amperecomputing.com \
--cc=irogers@google.com \
--cc=james.clark@linaro.org \
--cc=john.g.garry@oracle.com \
--cc=jolsa@kernel.org \
--cc=kan.liang@linux.intel.com \
--cc=leo.yan@linux.dev \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mathieu.poirier@linaro.org \
--cc=mike.leach@linaro.org \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=scclevenger@os.amperecomputing.com \
--cc=suzuki.poulose@arm.com \
--cc=tianruidong@linux.alibaba.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).