From: Thomas Richter <tmricht@linux.ibm.com>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Namhyung Kim <namhyung@kernel.org>,
linux-kernel@vger.kernel.org, linux-s390@vger.kernel.org,
linux-perf-users@vger.kernel.org, acme@kernel.org,
agordeev@linux.ibm.com, gor@linux.ibm.com,
sumanthk@linux.ibm.com, hca@linux.ibm.com, japo@linux.ibm.com
Subject: Re: [PATCH Linux-next] perf test: Fix test case perf trace BTF general tests
Date: Thu, 27 Nov 2025 07:28:44 +0100 [thread overview]
Message-ID: <389e0ed1-a46b-4ad0-aaab-da59cde2067e@linux.ibm.com> (raw)
In-Reply-To: <20251126102401.37af98bb@gandalf.local.home>
On 11/26/25 16:24, Steven Rostedt wrote:
> On Wed, 26 Nov 2025 08:13:00 +0100
> Thomas Richter <tmricht@linux.ibm.com> wrote:
>
>>>> I haven't tried it without the patches. Does it usually show what "buf" is?
>>>> Now with the reading of user space, it can show the content too!
>>>
>>> Yep, it reads the content using BPF. This is on my 6.16 kernel.
>>>
>>> $ sudo perf trace -e write -- /bin/echo hello
>>> hello
>>> 0.000 ( 0.014 ms): echo/61922 write(fd: 1, buf: hello\10, count: 6) = 6
>>>
>>> Thanks,
>>> Namhyung
>>>
>>>
>>
>> Hello Namhyung, Steven,
>>
>> friendly ping... any progress here?
>>
>
> I honestly have no clue how to fix this, as I don't even know where to
> look. Is it BPF that is messing up? If so, where's the BPF program that is
> doing this.
Yeah, sounds very familiar... happens to me all the time :-)>
> I thought BPF is supposed to handle updates and should never cause API
> breakage?
>
> I'll continue to look at the builtin-trace.c, but it seems that the BPF
> program it's attached to is handing it garbage with:
>
> perf trace -e syscalls:sys_enter_write
>
> The new fields are at the end. The BPF program should simply ignore those
> values. But again, I don't know where this BPF program lives.
>
> -- Steve
Ok, this sounds that the issue will linger around for some time.
Can we then adopt the test case check for perf test case 'perf trace BTF general tests'
to accept that strange 4th parameter?
Right now this test fails on a daily basis in linux-next and will most likely be in linux repo
soon, where it will also fail.
This is sort of 'unfortunate' that our daily continuous integration testing reports several errors
per day...
If you guys object to that fix I sent out a few days ago (which is absolutely ok),
I will disable the test in our CI test suite.
Thanks a lot.
--
Thomas Richter, Dept 3303, IBM s390 Linux Development, Boeblingen, Germany
--
IBM Deutschland Research & Development GmbH
Vorsitzender des Aufsichtsrats: Wolfgang Wendt
Geschäftsführung: David Faller
Sitz der Gesellschaft: Böblingen / Registergericht: Amtsgericht Stuttgart, HRB 243294
next prev parent reply other threads:[~2025-11-27 6:28 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-17 12:43 [PATCH Linux-next] perf test: Fix test case perf trace BTF general tests Thomas Richter
2025-11-18 1:58 ` Namhyung Kim
2025-11-18 6:15 ` Thomas Richter
2025-11-18 6:43 ` Namhyung Kim
2025-11-18 18:24 ` Steven Rostedt
2025-11-19 4:36 ` Namhyung Kim
2025-11-19 17:59 ` Steven Rostedt
2025-11-20 0:52 ` Namhyung Kim
2025-11-26 7:13 ` Thomas Richter
2025-11-26 15:24 ` Steven Rostedt
2025-11-26 17:12 ` Steven Rostedt
2025-11-26 17:37 ` Steven Rostedt
2025-11-26 18:57 ` Namhyung Kim
2025-11-26 19:01 ` Howard Chu
2025-11-27 6:28 ` Thomas Richter [this message]
2025-11-18 18:30 ` Jan Polensky
2025-11-19 7:55 ` Thomas Richter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=389e0ed1-a46b-4ad0-aaab-da59cde2067e@linux.ibm.com \
--to=tmricht@linux.ibm.com \
--cc=acme@kernel.org \
--cc=agordeev@linux.ibm.com \
--cc=gor@linux.ibm.com \
--cc=hca@linux.ibm.com \
--cc=japo@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=namhyung@kernel.org \
--cc=rostedt@goodmis.org \
--cc=sumanthk@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).