From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3FA10ECAAA1 for ; Wed, 7 Sep 2022 02:49:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229945AbiIGCtI (ORCPT ); Tue, 6 Sep 2022 22:49:08 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53162 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229941AbiIGCtH (ORCPT ); Tue, 6 Sep 2022 22:49:07 -0400 Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C8C1699244; Tue, 6 Sep 2022 19:49:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1662518946; x=1694054946; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=TbbV0IomhaWuQjuUgb4smhj3MDYoJe79ICKh/fMwL9w=; b=KMDBLyCW3KTOLufB05nBwSF5A8SxeLKZYB2gssPGqZua3dEow2k3N1CV 6MPDjOeBQNHoOhr+0ZIE4W2FAb9zQDyZRsVX/jUkiaOqx52xgWxgQ9Vh4 g+K9vQYKZ4RIge5E/26/j+oJmmbD+bbxK9V/3HNotyCC8rMqLJWqpZtDo EjYrywx3CWugpEDUxslrHJGo+TrQdU3tihQzGo9YC49p1wwovmrA9zoeX BmNJpRMeSHaLwqNy/wYGqoB3+RKGEmAMGLJFZNamGFPlHzbcREM0wJs7K STIj6d/xhWcc8sWzHkI69alXZV/hwwhQH9mJql9tr3NsXsB/wQzt3X6i4 Q==; X-IronPort-AV: E=McAfee;i="6500,9779,10462"; a="294347905" X-IronPort-AV: E=Sophos;i="5.93,295,1654585200"; d="scan'208";a="294347905" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Sep 2022 19:49:06 -0700 X-IronPort-AV: E=Sophos;i="5.93,295,1654585200"; d="scan'208";a="644422467" Received: from xingzhen-mobl.ccr.corp.intel.com (HELO [10.238.4.113]) ([10.238.4.113]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Sep 2022 19:49:03 -0700 Message-ID: <3aa4c863-24cc-9fdf-9960-2b1983b3322b@linux.intel.com> Date: Wed, 7 Sep 2022 10:49:01 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.2.1 Subject: Re: [PATCH] perf script: Skip dummy event attr check Content-Language: en-US To: Arnaldo Carvalho de Melo , Ian Rogers , Jiri Olsa Cc: Hongtao Yu , Namhyung Kim , lkml , Peter Zijlstra , Ingo Molnar , Mark Rutland , Alexander Shishkin , linux-perf-users@vger.kernel.org, "Liang, Kan" References: <20220831124041.219925-1-jolsa@kernel.org> From: Xing Zhengjun In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-perf-users@vger.kernel.org Hi, On 9/1/2022 12:23 AM, Arnaldo Carvalho de Melo wrote: > Em Wed, Aug 31, 2022 at 09:02:46AM -0700, Ian Rogers escreveu: >> On Wed, Aug 31, 2022 at 5:40 AM Jiri Olsa wrote: >>> >>> Hongtao Yu reported problem when displaying uregs in perf script >>> for system wide perf.data: >>> >>> # perf script -F uregs | head -10 >>> Samples for 'dummy:HG' event do not have UREGS attribute set. Cannot print 'uregs' field. >>> >>> The problem is the extra dummy event added for system wide, >>> which does not have proper sample_type setup. >>> >>> Skipping attr check completely for dummy event as suggested >>> by Namhyung, because it does not have any samples anyway. >>> >>> Reported-by: Hongtao Yu >>> Suggested-by: Namhyung Kim >>> Signed-off-by: Jiri Olsa >> >> Acked-by: Ian Rogers > > Thanks, applied to perf/urgent. > > - Arnaldo I have met a similar issue on hybrid systems such as ADL, I apply the patch, and it works OK for the normal mode. # ./perf record --intr-regs=di,r8,dx,cx -e br_inst_retired.near_call:p -c 1000 --per-thread true [ perf record: Woken up 1 times to write data ] [ perf record: Captured and wrote 0.024 MB perf.data (25 samples) ] # ./perf script -F iregs |head -5 ABI:2 CX:0xffff90e19d024ed8 DX:0x1 DI:0xffff90e19d024ed8 R8:0xffffba5e437e7b30 ABI:2 CX:0x7f5239783000 DX:0x80000000 DI:0xffff90e1801eea00 R8:0x71 ABI:2 CX:0x40 DX:0x60 DI:0xffffffff9fde5ab8 R8:0x40 ABI:2 CX:0x0 DX:0xffffffffffffffff DI:0xffff90e1877408e8 R8:0x1 ABI:2 CX:0xcc0 DX:0x1 DI:0xffff90e187d17c60 R8:0x40 But the issue still happened when running the test in the pipe mode. In the pipe mode, it calls process_attr() which still checks the attr for the dummy event, so the issue happened. # ./perf record -o - --intr-regs=di,r8,dx,cx -e br_inst_retired.near_call:p -c 1000 --per-thread true 2>/dev/null|./perf script -F iregs |head -5 Samples for 'dummy:HG' event do not have IREGS attribute set. Cannot print 'iregs' field. 0x120 [0x90]: failed to process type: 64 I have one test patch which can fix the pipe mode issue. ./perf record -o - --intr-regs=di,r8,dx,cx -e br_inst_retired.near_call:p -c 1000 --per-thread true 2>/dev/null|./perf script -F iregs |head -5 ABI:2 CX:0xffff90e18119e278 DX:0x0 DI:0xffff90e18119f858 R8:0xffff90e18119e278 ABI:2 CX:0x0 DX:0x1 DI:0xfffffa2844a91580 R8:0x402 ABI:2 CX:0x0 DX:0x0 DI:0x100cca R8:0x0 ABI:2 CX:0x0 DX:0x0 DI:0xffffffff9e997ca5 R8:0x0 ABI:2 CX:0x113ce8000 DX:0xffff90e198f46600 DI:0xffff90e189de8000 R8:0x290 Fixes: b91e5492f9d7 ("perf record: Add a dummy event on hybrid systems to collect metadata records") Signed-off-by: Zhengjun Xing --- tools/perf/builtin-script.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tools/perf/builtin-script.c b/tools/perf/builtin-script.c index 9152e3e45b69..2d863cdb19fe 100644 --- a/tools/perf/builtin-script.c +++ b/tools/perf/builtin-script.c @@ -2429,6 +2429,8 @@ static int process_attr(struct perf_tool *tool, union perf_event *event, } if (evsel->core.attr.sample_type) { + if (evsel__is_dummy_event(evsel)) + return 0; err = evsel__check_attr(evsel, scr->session); if (err) return err; -- 2.25.1 -- Zhengjun Xing