From: Adrian Hunter <adrian.hunter@intel.com>
To: Changbin Du <changbin.du@huawei.com>
Cc: Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@kernel.org>, Namhyung Kim <namhyung@kernel.org>,
Ian Rogers <irogers@google.com>,
linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org,
Andi Kleen <ak@linux.intel.com>,
Thomas Richter <tmricht@linux.ibm.com>,
changbin.du@gmail.com
Subject: Re: [PATCH v3 3/5] perf: script: add field 'insn_disam' to display mnemonic instructions
Date: Fri, 19 Jan 2024 08:29:08 +0200 [thread overview]
Message-ID: <3d5266d5-e5e1-49f9-8fb3-b736dc79e5e6@intel.com> (raw)
In-Reply-To: <20240119035735.y427wcmsm7dow6h4@M910t>
On 19/01/24 05:57, Changbin Du wrote:
> On Thu, Jan 18, 2024 at 09:49:41PM +0200, Adrian Hunter wrote:
>> On 18/01/24 06:12, Changbin Du wrote:
>>> In addition to the 'insn' field, this adds a new field 'insn_disam' to
>>> display mnemonic instructions instead of the raw code.
>>
>> 'disam' seems an unusual abbreviation, and the 'insn' part seems a bit
>> redundant. Could this be just 'disasm' instead of 'insn_disam'?
>
> Personally, I'd preserve the insn_ prefix. So we have two related fields 'insn'
> and 'insn_disasm'.
>
'ip', 'sym' 'dso' are all related but do not have a common prefix. Also
most of the field names lean towards abbreviation.
next prev parent reply other threads:[~2024-01-19 6:29 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-18 4:12 [PATCH v3 0/5] perf: script: Intro capstone disasm engine to show instruction trace Changbin Du
2024-01-18 4:12 ` [PATCH v3 1/5] perf: build: introduce the libcapstone Changbin Du
2024-01-18 4:12 ` [PATCH v3 2/5] perf: util: use capstone disasm engine to show assembly instructions Changbin Du
2024-01-18 4:12 ` [PATCH v3 3/5] perf: script: add field 'insn_disam' to display mnemonic instructions Changbin Du
2024-01-18 19:49 ` Adrian Hunter
2024-01-19 3:57 ` Changbin Du
2024-01-19 6:29 ` Adrian Hunter [this message]
2024-01-19 10:04 ` Changbin Du
2024-01-18 4:12 ` [PATCH v3 4/5] perf: script: add raw|disam arguments to --insn-trace option Changbin Du
2024-01-18 4:12 ` [PATCH v3 5/5] perf: script: prefer capstone to XED Changbin Du
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3d5266d5-e5e1-49f9-8fb3-b736dc79e5e6@intel.com \
--to=adrian.hunter@intel.com \
--cc=acme@kernel.org \
--cc=ak@linux.intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=changbin.du@gmail.com \
--cc=changbin.du@huawei.com \
--cc=irogers@google.com \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=tmricht@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).