* [PATCH] perf arm: Fix off-by-one directory path.
@ 2022-01-14 6:48 Ian Rogers
2022-01-14 9:26 ` German Gomez
0 siblings, 1 reply; 3+ messages in thread
From: Ian Rogers @ 2022-01-14 6:48 UTC (permalink / raw)
To: Peter Zijlstra, Ingo Molnar, Arnaldo Carvalho de Melo,
Mark Rutland, Alexander Shishkin, Jiri Olsa, Namhyung Kim,
Alexandre Truong, German Gomez, James Clark, Athira Jajeev,
linux-perf-users, linux-kernel
Cc: Ian Rogers
Relative path include works in the regular build due to -I paths but may
fail in other situations.
Fixes: 83869019c74c ("perf arch: Support register names from all archs")
Signed-off-by: Ian Rogers <irogers@google.com>
---
tools/perf/util/arm64-frame-pointer-unwind-support.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/perf/util/arm64-frame-pointer-unwind-support.c b/tools/perf/util/arm64-frame-pointer-unwind-support.c
index 4f5ecf51ed38..2242a885fbd7 100644
--- a/tools/perf/util/arm64-frame-pointer-unwind-support.c
+++ b/tools/perf/util/arm64-frame-pointer-unwind-support.c
@@ -6,7 +6,7 @@
#include "unwind.h"
#define perf_event_arm_regs perf_event_arm64_regs
-#include "../arch/arm64/include/uapi/asm/perf_regs.h"
+#include "../../arch/arm64/include/uapi/asm/perf_regs.h"
#undef perf_event_arm_regs
struct entries {
--
2.34.1.703.g22d0c6ccf7-goog
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] perf arm: Fix off-by-one directory path.
2022-01-14 6:48 [PATCH] perf arm: Fix off-by-one directory path Ian Rogers
@ 2022-01-14 9:26 ` German Gomez
2022-01-14 14:32 ` Arnaldo Carvalho de Melo
0 siblings, 1 reply; 3+ messages in thread
From: German Gomez @ 2022-01-14 9:26 UTC (permalink / raw)
To: Ian Rogers, Peter Zijlstra, Ingo Molnar, Arnaldo Carvalho de Melo,
Mark Rutland, Alexander Shishkin, Jiri Olsa, Namhyung Kim,
Alexandre Truong, James Clark, Athira Jajeev, linux-perf-users,
linux-kernel
Hi Ian,
I think there's another include in "utils/intel-pt.c" that may need the same treatment.
On 14/01/2022 06:48, Ian Rogers wrote:
> Relative path include works in the regular build due to -I paths but may
> fail in other situations.
>
> Fixes: 83869019c74c ("perf arch: Support register names from all archs")
> Signed-off-by: Ian Rogers <irogers@google.com>
Reviewed-by: German Gomez <german.gomez@arm.com>
Thanks,
German
> ---
> tools/perf/util/arm64-frame-pointer-unwind-support.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/perf/util/arm64-frame-pointer-unwind-support.c b/tools/perf/util/arm64-frame-pointer-unwind-support.c
> index 4f5ecf51ed38..2242a885fbd7 100644
> --- a/tools/perf/util/arm64-frame-pointer-unwind-support.c
> +++ b/tools/perf/util/arm64-frame-pointer-unwind-support.c
> @@ -6,7 +6,7 @@
> #include "unwind.h"
>
> #define perf_event_arm_regs perf_event_arm64_regs
> -#include "../arch/arm64/include/uapi/asm/perf_regs.h"
> +#include "../../arch/arm64/include/uapi/asm/perf_regs.h"
> #undef perf_event_arm_regs
>
> struct entries {
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] perf arm: Fix off-by-one directory path.
2022-01-14 9:26 ` German Gomez
@ 2022-01-14 14:32 ` Arnaldo Carvalho de Melo
0 siblings, 0 replies; 3+ messages in thread
From: Arnaldo Carvalho de Melo @ 2022-01-14 14:32 UTC (permalink / raw)
To: German Gomez
Cc: Ian Rogers, Peter Zijlstra, Ingo Molnar, Mark Rutland,
Alexander Shishkin, Jiri Olsa, Namhyung Kim, Alexandre Truong,
James Clark, Athira Jajeev, linux-perf-users, linux-kernel
Em Fri, Jan 14, 2022 at 09:26:29AM +0000, German Gomez escreveu:
> Hi Ian,
>
> I think there's another include in "utils/intel-pt.c" that may need the same treatment.
>
> On 14/01/2022 06:48, Ian Rogers wrote:
> > Relative path include works in the regular build due to -I paths but may
> > fail in other situations.
> >
> > Fixes: 83869019c74c ("perf arch: Support register names from all archs")
> > Signed-off-by: Ian Rogers <irogers@google.com>
> Reviewed-by: German Gomez <german.gomez@arm.com>
Thanks, applied.
- Arnaldo
> Thanks,
> German
> > ---
> > tools/perf/util/arm64-frame-pointer-unwind-support.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/tools/perf/util/arm64-frame-pointer-unwind-support.c b/tools/perf/util/arm64-frame-pointer-unwind-support.c
> > index 4f5ecf51ed38..2242a885fbd7 100644
> > --- a/tools/perf/util/arm64-frame-pointer-unwind-support.c
> > +++ b/tools/perf/util/arm64-frame-pointer-unwind-support.c
> > @@ -6,7 +6,7 @@
> > #include "unwind.h"
> >
> > #define perf_event_arm_regs perf_event_arm64_regs
> > -#include "../arch/arm64/include/uapi/asm/perf_regs.h"
> > +#include "../../arch/arm64/include/uapi/asm/perf_regs.h"
> > #undef perf_event_arm_regs
> >
> > struct entries {
--
- Arnaldo
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-01-14 14:32 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-01-14 6:48 [PATCH] perf arm: Fix off-by-one directory path Ian Rogers
2022-01-14 9:26 ` German Gomez
2022-01-14 14:32 ` Arnaldo Carvalho de Melo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).