linux-perf-users.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Milian Wolff <milian.wolff@kdab.com>
To: linux-perf-users@vger.kernel.org
Subject: Re: usability issues with inlining and backtraces
Date: Mon, 15 Aug 2016 13:32:24 +0200	[thread overview]
Message-ID: <4329099.drS591pfTr@milian-kdab2> (raw)
In-Reply-To: <16720652.kfi49F7aVl@milian-kdab2>

[-- Attachment #1: Type: text/plain, Size: 1633 bytes --]

On Monday, August 15, 2016 11:32:33 AM CEST Milian Wolff wrote:
> On Monday, June 13, 2016 6:07:13 PM CEST Milian Wolff wrote:
> > Ping?
> > 
> > Andi, I'd be very interested in your answers on my questions below. Most
> > notably, `srcline` with `--call-graph ...,address` seems to be highly
> > buggy
> > for me.
> 
> Reping again.
> 
> Andi, or anyone else - I would really appreciate some more feedback on my
> questions below.
> 
> I esp. wonder how to leverage srcline and addresses in the call-graph, as
> that has the potential to greatly increase perf's value to me.

OK, I have found at least two culprits that partially explain the behavior.

On one hand, I'm simply missing debug information for some libraries, such as 
libm, libc etc. pp. Due to that, the addr2line step fails and sym+offset is 
displayed.

On the other hand, there seems to be a bug in perf: 

When hist_entry__get_srcline calls get_srcline I see from debug output

he->ip=307e, sym=main -> rip_obj2dump=40307e -> mandelbrot.h:39

But in callchain_list__sym_name, I see:

cl->ip=40373d, sym=main -> rip_obj2dump=80373d-> main+8390413

So it seems like the callchain_list is missing a normalization step that is 
applied to the IP addresses stored in hist_entry. Can someone point me into 
the right direction?

If I change callchain_list__sym_name to pass cl->ip - cl->ms.map->start to 
map__rip_2objdump this feature works much better for me, but I doubt that this 
is the correct fix.

Thanks
-- 
Milian Wolff | milian.wolff@kdab.com | Software Engineer
KDAB (Deutschland) GmbH&Co KG, a KDAB Group company
Tel: +49-30-521325470
KDAB - The Qt Experts

[-- Attachment #2: smime.p7s --]
[-- Type: application/pkcs7-signature, Size: 5903 bytes --]

  reply	other threads:[~2016-08-15 11:32 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-05-23  9:10 usability issues with inlining and backtraces Milian Wolff
2016-05-23 14:11 ` Arnaldo Carvalho de Melo
2016-08-15 11:44   ` Milian Wolff
2016-05-23 14:59 ` Andi Kleen
2016-05-23 15:18   ` Milian Wolff
2016-06-13 16:07     ` Milian Wolff
2016-08-15  9:32       ` Milian Wolff
2016-08-15 11:32         ` Milian Wolff [this message]
2016-08-15 17:13           ` Andi Kleen
2016-08-16 15:13             ` Namhyung Kim
2016-08-16 15:45               ` Milian Wolff

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4329099.drS591pfTr@milian-kdab2 \
    --to=milian.wolff@kdab.com \
    --cc=linux-perf-users@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).