From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 53B14194A54; Fri, 24 Jan 2025 16:37:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.163.158.5 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737736652; cv=none; b=MDdN69EcysO6tI1hjIAASPiyp1BSygehqhXF2IA7XkSPSrd4b9I1TwqZl0+bYQRTwcoWSBJ/4DyXZItEQYHSpGy/RaEJKTC/XcnQZ8nvT7DCKDuCq3hQiFNZbLe2dWby2PWFae46s4OQ8jciWVZFaBPpsN5ifL1KXJeEjZrChTo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737736652; c=relaxed/simple; bh=Et1B7SHgJ0igZV/wuor2UqkCUM7KBHRuHWjBxlCBsbc=; h=Message-ID:Date:MIME-Version:From:Subject:To:Cc:References: In-Reply-To:Content-Type; b=TaU03sz009JZA2h3CqFcYEqhmTMJiNytrdfkjAq30PrVneIt0UWrBNx7G6pq0i64IpFNN6zuu33JVfzGeBoK1/FiqPNQBeIeigxjJ5l8rO0exi1s3d6htfwccRQTdjcTM1N6patz7lyqhRVnZ/0NheW7z7QWrTpPUwsEN72pDXk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.ibm.com; spf=pass smtp.mailfrom=linux.ibm.com; dkim=pass (2048-bit key) header.d=ibm.com header.i=@ibm.com header.b=Ml9ePL9H; arc=none smtp.client-ip=148.163.158.5 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.ibm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.ibm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ibm.com header.i=@ibm.com header.b="Ml9ePL9H" Received: from pps.filterd (m0353725.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 50OEEILN008555; Fri, 24 Jan 2025 16:36:44 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=pp1; bh=3h/kni 1OcltjjXLxvpcXppk0b03ArmQBNpHX48ITn2M=; b=Ml9ePL9HTBRNp8QKc4drqr IrZz20Nx4U7ymr9RzdnSuzF5JuW26gK7thtKk45abSgHGv3jX5hNM7G4J1YCf36e mFMWP/JJ+EP/0OsOtrKtxCOAQKjBtDk+33T8sIveBetW65zKIGTFKjef6530qV7H sOWIOAWYmIJQGiEw9waNfR3Mxnd9Kw3t/hY8AxQTRNB5RH9Nh+BkEx9SP1sAcRrW 02w3sTjM3mDkLsFBMsWiDAF3IlKAAuIFepDN/Gv32MZTRaVaqlDlWiPJEoRJ7IL1 g7NAvTCTUEQ3GJE9J+fsO6ImENk4sF4GPMYBbBH9Kj5Wx/p6rUXMsIDTFg4iCGyA == Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 44c1pyvkn3-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 24 Jan 2025 16:36:43 +0000 (GMT) Received: from m0353725.ppops.net (m0353725.ppops.net [127.0.0.1]) by pps.reinject (8.18.0.8/8.18.0.8) with ESMTP id 50OGahuL020004; Fri, 24 Jan 2025 16:36:43 GMT Received: from ppma22.wdc07v.mail.ibm.com (5c.69.3da9.ip4.static.sl-reverse.com [169.61.105.92]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 44c1pyvkmx-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 24 Jan 2025 16:36:43 +0000 (GMT) Received: from pps.filterd (ppma22.wdc07v.mail.ibm.com [127.0.0.1]) by ppma22.wdc07v.mail.ibm.com (8.18.1.2/8.18.1.2) with ESMTP id 50OFDrsn024252; Fri, 24 Jan 2025 16:36:42 GMT Received: from smtprelay04.fra02v.mail.ibm.com ([9.218.2.228]) by ppma22.wdc07v.mail.ibm.com (PPS) with ESMTPS id 448q0ymeax-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 24 Jan 2025 16:36:42 +0000 Received: from smtpav03.fra02v.mail.ibm.com (smtpav03.fra02v.mail.ibm.com [10.20.54.102]) by smtprelay04.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 50OGaeLj33358438 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 24 Jan 2025 16:36:40 GMT Received: from smtpav03.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 25F5F2004B; Fri, 24 Jan 2025 16:36:40 +0000 (GMT) Received: from smtpav03.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 2E98B20043; Fri, 24 Jan 2025 16:36:39 +0000 (GMT) Received: from [9.171.221.90] (unknown [9.171.221.90]) by smtpav03.fra02v.mail.ibm.com (Postfix) with ESMTP; Fri, 24 Jan 2025 16:36:39 +0000 (GMT) Message-ID: <4379b9c6-e896-4ea4-a4a5-9c6b3c9f2f75@linux.ibm.com> Date: Fri, 24 Jan 2025 17:36:38 +0100 Precedence: bulk X-Mailing-List: linux-perf-users@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: Jens Remus Subject: Re: [PATCH v4 19/39] unwind_user/sframe: Add support for reading .sframe contents To: Josh Poimboeuf , x86@kernel.org Cc: Peter Zijlstra , Steven Rostedt , Ingo Molnar , Arnaldo Carvalho de Melo , linux-kernel@vger.kernel.org, Indu Bhagat , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , Ian Rogers , Adrian Hunter , linux-perf-users@vger.kernel.org, Mark Brown , linux-toolchains@vger.kernel.org, Jordan Rome , Sam James , linux-trace-kernel@vger.kernel.org, Andrii Nakryiko , Mathieu Desnoyers , Florian Weimer , Andy Lutomirski , Masami Hiramatsu , Weinan Liu References: <77c0d1ec143bf2a53d66c4ecb190e7e0a576fbfd.1737511963.git.jpoimboe@kernel.org> Content-Language: en-US Organization: IBM Deutschland Research & Development GmbH In-Reply-To: <77c0d1ec143bf2a53d66c4ecb190e7e0a576fbfd.1737511963.git.jpoimboe@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-TM-AS-GCONF: 00 X-Proofpoint-ORIG-GUID: vnh1RLZ14a7miVU9hcm8_6SSs_G_SDlL X-Proofpoint-GUID: Ec27uQR5MzHaw_t3hmt6KSDC-UlAmv5Q X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1057,Hydra:6.0.680,FMLib:17.12.68.34 definitions=2025-01-24_07,2025-01-23_01,2024-11-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 phishscore=0 mlxlogscore=999 bulkscore=0 lowpriorityscore=0 spamscore=0 mlxscore=0 priorityscore=1501 adultscore=0 impostorscore=0 malwarescore=0 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2411120000 definitions=main-2501240116 On 22.01.2025 03:31, Josh Poimboeuf wrote: > diff --git a/include/linux/sframe.h b/include/linux/sframe.h > @@ -3,11 +3,14 @@ > #define _LINUX_SFRAME_H > > #include > +#include > #include > > #ifdef CONFIG_HAVE_UNWIND_USER_SFRAME > > struct sframe_section { > + struct rcu_head rcu; > + Nit: You are adding a blank line, that you later remove with "[PATCH v4 25/39] unwind_user/sframe: Show file name in debug output". > unsigned long sframe_start; > unsigned long sframe_end; > unsigned long text_start; Regards, Jens -- Jens Remus Linux on Z Development (D3303) +49-7031-16-1128 Office jremus@de.ibm.com IBM IBM Deutschland Research & Development GmbH; Vorsitzender des Aufsichtsrats: Wolfgang Wendt; Geschäftsführung: David Faller; Sitz der Gesellschaft: Böblingen; Registergericht: Amtsgericht Stuttgart, HRB 243294 IBM Data Privacy Statement: https://www.ibm.com/privacy/