* [PATCH] perf lzma: Fix return value in lzma_is_compressed()
@ 2025-08-28 10:50 Miaoqian Lin
2025-10-11 3:47 ` Mi, Dapeng
0 siblings, 1 reply; 2+ messages in thread
From: Miaoqian Lin @ 2025-08-28 10:50 UTC (permalink / raw)
To: Peter Zijlstra, Ingo Molnar, Arnaldo Carvalho de Melo,
Namhyung Kim, Mark Rutland, Alexander Shishkin, Jiri Olsa,
Ian Rogers, Adrian Hunter, Liang, Kan, Stephen Brennan,
linux-perf-users, linux-kernel
Cc: linmq006, stable
lzma_is_compressed() returns -1 on error but is declared as bool.
And -1 gets converted to true, which could be misleading.
Return false instead to match the declared type.
Fixes: 4b57fd44b61b ("perf tools: Add lzma_is_compressed function")
Cc: <stable@vger.kernel.org>
Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
---
tools/perf/util/lzma.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/perf/util/lzma.c b/tools/perf/util/lzma.c
index bbcd2ffcf4bd..c355757ed391 100644
--- a/tools/perf/util/lzma.c
+++ b/tools/perf/util/lzma.c
@@ -120,7 +120,7 @@ bool lzma_is_compressed(const char *input)
ssize_t rc;
if (fd < 0)
- return -1;
+ return false;
rc = read(fd, buf, sizeof(buf));
close(fd);
--
2.39.5 (Apple Git-154)
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] perf lzma: Fix return value in lzma_is_compressed()
2025-08-28 10:50 [PATCH] perf lzma: Fix return value in lzma_is_compressed() Miaoqian Lin
@ 2025-10-11 3:47 ` Mi, Dapeng
0 siblings, 0 replies; 2+ messages in thread
From: Mi, Dapeng @ 2025-10-11 3:47 UTC (permalink / raw)
To: Miaoqian Lin, Peter Zijlstra, Ingo Molnar,
Arnaldo Carvalho de Melo, Namhyung Kim, Mark Rutland,
Alexander Shishkin, Jiri Olsa, Ian Rogers, Adrian Hunter,
Liang, Kan, Stephen Brennan, linux-perf-users, linux-kernel
Cc: stable
On 8/28/2025 6:50 PM, Miaoqian Lin wrote:
> lzma_is_compressed() returns -1 on error but is declared as bool.
> And -1 gets converted to true, which could be misleading.
> Return false instead to match the declared type.
>
> Fixes: 4b57fd44b61b ("perf tools: Add lzma_is_compressed function")
> Cc: <stable@vger.kernel.org>
> Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
> ---
> tools/perf/util/lzma.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/perf/util/lzma.c b/tools/perf/util/lzma.c
> index bbcd2ffcf4bd..c355757ed391 100644
> --- a/tools/perf/util/lzma.c
> +++ b/tools/perf/util/lzma.c
> @@ -120,7 +120,7 @@ bool lzma_is_compressed(const char *input)
> ssize_t rc;
>
> if (fd < 0)
> - return -1;
> + return false;
>
> rc = read(fd, buf, sizeof(buf));
> close(fd);
Reviewed-by: Dapeng Mi <dapeng1.mi@linux.intel.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-10-11 3:47 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-08-28 10:50 [PATCH] perf lzma: Fix return value in lzma_is_compressed() Miaoqian Lin
2025-10-11 3:47 ` Mi, Dapeng
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).