From: Avi Kivity <avi@redhat.com>
To: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
Cc: linux-perf-users@vger.kernel.org, kvm@vger.kernel.org,
Steven Rostedt <rostedt@goodmis.org>
Subject: Re: [RFC 0/2] KVM: Fix kvm_exit trace event format
Date: Wed, 27 Jul 2011 15:59:21 +0300 [thread overview]
Message-ID: <4E300BA9.8010202@redhat.com> (raw)
In-Reply-To: <20110727125506.GA21024@stefanha-thinkpad.localdomain>
On 07/27/2011 03:55 PM, Stefan Hajnoczi wrote:
> >
> > trace-cmd has a plugin API (and a kvm plugin) that you can use for
> > this, and I expect perf either does as well or can make use of one.
> > I don't think it's useful to complicate the print format description
> > further to support our weird use case.
>
> The problem with relying on a plugin is that every userspace application
> (currently two that I am aware of: perf and trace-cmd) has to add
> special-case kvm code to work around our crappy format.
Move the plugins to tools/trace-formats and install them in
/lib/modules/$(uname -r)/tracepoint-formats/*.so.
> With these patches we at least get back to an event format that is
> self-describing - no plugin necessary.
There will always be special cases. Look at how trace-cmd formats the
kvm_emulate_insn event.
--
error compiling committee.c: too many arguments to function
next prev parent reply other threads:[~2011-07-27 12:59 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-22 11:46 [RFC 0/2] KVM: Fix kvm_exit trace event format Stefan Hajnoczi
2011-07-22 11:46 ` [RFC 1/2] KVM: Record instruction set in all vmexit tracepoints Stefan Hajnoczi
2011-07-22 11:46 ` [RFC 2/2] KVM: Use __print_symbolic() for " Stefan Hajnoczi
2011-07-27 11:47 ` [RFC 0/2] KVM: Fix kvm_exit trace event format Avi Kivity
2011-07-27 12:55 ` Stefan Hajnoczi
2011-07-27 12:59 ` Avi Kivity [this message]
2011-07-27 13:19 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E300BA9.8010202@redhat.com \
--to=avi@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=rostedt@goodmis.org \
--cc=stefanha@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).