From mboxrd@z Thu Jan  1 00:00:00 1970
From: David Ahern <dsahern@gmail.com>
Subject: Re: [PATCH v2] perf tool: fix endianness handling of u32 data in
 samples
Date: Fri, 02 Sep 2011 13:12:30 -0600
Message-ID: <4E612A9E.5000807@gmail.com>
References: <1314979426-29356-1-git-send-email-dsahern@gmail.com> <20110902181818.GD17970@ghostprotocols.net>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Return-path: <linux-perf-users-owner@vger.kernel.org>
Received: from mail-yi0-f46.google.com ([209.85.218.46]:44709 "EHLO
	mail-yi0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1754342Ab1IBTMf (ORCPT
	<rfc822;linux-perf-users@vger.kernel.org>);
	Fri, 2 Sep 2011 15:12:35 -0400
In-Reply-To: <20110902181818.GD17970@ghostprotocols.net>
Sender: linux-perf-users-owner@vger.kernel.org
List-ID: <linux-perf-users.vger.kernel.org>
To: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>
Cc: linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org, mingo@elte.hu, peterz@infradead.org, fweisbec@gmail.com, paulus@samba.org, tglx@linutronix.de, anton@samba.org

On 09/02/2011 12:18 PM, Arnaldo Carvalho de Melo wrote:
> Em Fri, Sep 02, 2011 at 10:03:46AM -0600, David Ahern escreveu:
>>  	if (type & PERF_SAMPLE_RAW) {
>> -		u32 *p = (u32 *)array;
>> +		u.val64 = *array;
>> +		if (swapped) {
>> +			static bool show_warn = true;
>> +
>> +			/* undo swap of u64, then swap on individual u32s */
>> +			u.val64 = bswap_64(u.val64);
>> +			u.val32[0] = bswap_32(u.val32[0]);
>> +			u.val32[1] = bswap_32(u.val32[1]);
>> +
>> +			if (show_warn) {
>> +				pr_warning("Endianness of raw data not corrected!\n");
>> +				show_warn = false;
>> +			}
>> +		}
> 
> Can you use WARN_ONCE? Would become:
> 	
> 		if (WARN_ONCE(swapped, "Endianness of raw data not corrected!\n")) {
> 			/* undo swap of u64, then swap on individual u32s */
> 			u.val64 = bswap_64(u.val64);
> 			u.val32[0] = bswap_32(u.val32[0]);
> 			u.val32[1] = bswap_32(u.val32[1]);
> 		}

That's not quite what we need. The bswap's happen all the time; the warn
once is to tell the user one time that samples in the file contain raw
data and those cannot be programmatically adjusted for endianness.

ie., more like:
    WARN_ONCE(swapped, "Endianness of raw data not corrected!\n");
and no action taken (the 'if (WARN_ONCE())'part).

David


> 
> We have that and its the usual idiom in the kernel proper :-)
> 
> See tools/perf/util/include/asm/bug.h and net/can/af_can.c can_rcv for
> an example.
> 
> Thanks,
> 
> - Arnaldo