From: Arun Sharma <asharma@fb.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: linux-perf-users@vger.kernel.org, acme@ghostprotocols.net,
mingo@elte.hu, Stephane Eranian <eranian@google.com>,
Frederic Weisbecker <fweisbec@gmail.com>,
Andrew Vagin <avagin@gmail.com>
Subject: Re: Profiling sleep times?
Date: Fri, 7 Oct 2011 10:58:42 -0700 [thread overview]
Message-ID: <4E8F3DD2.9000807@fb.com> (raw)
In-Reply-To: <1317951036.9813.12.camel@twins>
On 10/6/11 6:30 PM, Peter Zijlstra wrote:
>
> But the idea of the __perf_count() thing:
> [..]
> TP_perf_assign(
> __perf_count(delay);
> ),
>
> TP_printk("comm=%s pid=%d delay=%Lu [ns]",
> __entry->comm, __entry->pid,
> (unsigned long long)__entry->delay)
> );
>
>
> is that the counter is incremented with the delay, so the event should
> get weighted right.
>
> So having to get the delay out of the raw tracepoint data shouldn't be
> needed.
How does this work for dynamic tracepoints? Or tracepoints with multiple
dimensions where the user might want to query each dimension separately?
Andrew: what do you think about generalizing my patch to accept a
command line option(s) to specify which fields to use for the purpose of
computing the histogram?
For static tracepoints, TP_perf_assign() could act as a hint on which
field to default to.
-Arun
next prev parent reply other threads:[~2011-10-07 18:19 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-03 19:38 Profiling sleep times? Arun Sharma
2011-10-03 20:17 ` Peter Zijlstra
2011-10-03 21:53 ` Arun Sharma
2011-10-04 8:34 ` Peter Zijlstra
2011-10-06 21:56 ` Arun Sharma
2011-10-07 0:05 ` Arun Sharma
2011-10-07 1:30 ` Peter Zijlstra
2011-10-07 5:42 ` avagin
2011-10-07 9:33 ` Peter Zijlstra
2011-10-07 17:58 ` Arun Sharma [this message]
2011-10-07 23:16 ` avagin
2011-10-08 1:45 ` avagin
2011-10-10 18:50 ` Arun Sharma
2011-10-12 7:41 ` Ingo Molnar
2011-10-13 5:39 ` Andrew Vagin
2011-10-14 21:19 ` Arun Sharma
2011-10-15 17:00 ` Ingo Molnar
2011-10-15 19:22 ` Peter Zijlstra
2011-10-15 19:29 ` Peter Zijlstra
2011-10-18 1:07 ` Arun Sharma
2011-10-22 10:49 ` Frederic Weisbecker
2011-10-22 16:22 ` Andrew Wagin
2011-10-23 0:27 ` Arun Sharma
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E8F3DD2.9000807@fb.com \
--to=asharma@fb.com \
--cc=acme@ghostprotocols.net \
--cc=avagin@gmail.com \
--cc=eranian@google.com \
--cc=fweisbec@gmail.com \
--cc=linux-perf-users@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).