From: "avagin@gmail.com" <avagin@gmail.com>
To: Arun Sharma <asharma@fb.com>
Cc: Peter Zijlstra <peterz@infradead.org>,
linux-perf-users@vger.kernel.org, acme@ghostprotocols.net,
mingo@elte.hu, Stephane Eranian <eranian@google.com>,
Frederic Weisbecker <fweisbec@gmail.com>
Subject: Re: Profiling sleep times?
Date: Sat, 08 Oct 2011 03:16:28 +0400 [thread overview]
Message-ID: <4E8F884C.8010209@gmail.com> (raw)
In-Reply-To: <4E8F3DD2.9000807@fb.com>
Hello Arun,
> Andrew: what do you think about generalizing my patch to accept a
> command line option(s) to specify which fields to use for the purpose of
> computing the histogram?
I have no objection, but I don't think, that we really need that.
Now we have not got a real use case. All events which I've seen have not
more than one parameters, which may be used as weight and for this one
we already have parameter "period".
I already said, that you have trouble with sched_stat_sleed due to some
issues in kernel.
The first issue is that __perf_cout doesn't work and I sent the patch,
which fixes it. ([PATCH] perf: fix counter of ftrace events)
And the second issue is that the trace events are divided on some perf
events and their number is restricted by sysctl_perf_event_sample_rate/HZ.
I don't sure, that we should generate more than one "perf" event on each
"trace" event. I think the better way to use SAMPLE_PERIOD and now I
think in this direction.
If you want to fix the bug with sched_stat_sleep, you need to fix the
second issue. I found workaround for your case:
#./perf record -age sched:sched_stat_sleep --filter="comm == foo" -c
100000 -F 100000 -- ~/foo
# ./perf report
# Events: 5K sched:sched_stat_sleep
#
# Overhead Command Shared Object Symbol
# ........ ....... ................. ......
#
99.98% foo [unknown] [k] 0
|
--- schedule
|
|--80.20%-- schedule_hrtimeout_range_clock
| schedule_hrtimeout_range
| poll_schedule_timeout
| do_select
| core_sys_select
| sys_select
| system_call_fastpath
|
--19.80%-- do_nanosleep
hrtimer_nanosleep
sys_nanosleep
system_call_fastpath
>
> For static tracepoints, TP_perf_assign() could act as a hint on which
> field to default to.
>
> -Arun
next prev parent reply other threads:[~2011-10-07 23:16 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-03 19:38 Profiling sleep times? Arun Sharma
2011-10-03 20:17 ` Peter Zijlstra
2011-10-03 21:53 ` Arun Sharma
2011-10-04 8:34 ` Peter Zijlstra
2011-10-06 21:56 ` Arun Sharma
2011-10-07 0:05 ` Arun Sharma
2011-10-07 1:30 ` Peter Zijlstra
2011-10-07 5:42 ` avagin
2011-10-07 9:33 ` Peter Zijlstra
2011-10-07 17:58 ` Arun Sharma
2011-10-07 23:16 ` avagin [this message]
2011-10-08 1:45 ` avagin
2011-10-10 18:50 ` Arun Sharma
2011-10-12 7:41 ` Ingo Molnar
2011-10-13 5:39 ` Andrew Vagin
2011-10-14 21:19 ` Arun Sharma
2011-10-15 17:00 ` Ingo Molnar
2011-10-15 19:22 ` Peter Zijlstra
2011-10-15 19:29 ` Peter Zijlstra
2011-10-18 1:07 ` Arun Sharma
2011-10-22 10:49 ` Frederic Weisbecker
2011-10-22 16:22 ` Andrew Wagin
2011-10-23 0:27 ` Arun Sharma
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E8F884C.8010209@gmail.com \
--to=avagin@gmail.com \
--cc=acme@ghostprotocols.net \
--cc=asharma@fb.com \
--cc=eranian@google.com \
--cc=fweisbec@gmail.com \
--cc=linux-perf-users@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).